2020-06-12 06:01:05

by Herbert Xu

Subject: crypto: caam - Fix argument type in handle_imx6_err005766

The function handle_imx6_err005766 needs to take an __iomem argument
as otherwise sparse will generate two warnings.

Fixes: 33d69455e402 ("crypto: caam - limit AXI pipeline to a...")
Signed-off-by: Herbert Xu <[email protected]>

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index f3d20b7645e0..8ecfa97c3188 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -469,7 +469,7 @@ static int caam_get_era(struct caam_ctrl __iomem *ctrl)
* pipeline to a depth of 1 (from it's default of 4) to preclude this situation
* from occurring.
*/
-static void handle_imx6_err005766(u32 *mcr)
+static void handle_imx6_err005766(u32 __iomem *mcr)
{
if (of_machine_is_compatible("fsl,imx6q") ||
of_machine_is_compatible("fsl,imx6dl") ||
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2020-06-12 09:05:23

by Iuliana Prodan

Subject: Re: crypto: caam - Fix argument type in handle_imx6_err005766

On 6/12/2020 9:00 AM, Herbert Xu wrote:
> The function handle_imx6_err005766 needs to take an __iomem argument
> as otherwise sparse will generate two warnings.
>
> Fixes: 33d69455e402 ("crypto: caam - limit AXI pipeline to a...")
> Signed-off-by: Herbert Xu <[email protected]>
>
Reviewed-by: Iuliana Prodan <[email protected]>

Thanks,
Iulia

> diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> index f3d20b7645e0..8ecfa97c3188 100644
> --- a/drivers/crypto/caam/ctrl.c
> +++ b/drivers/crypto/caam/ctrl.c
> @@ -469,7 +469,7 @@ static int caam_get_era(struct caam_ctrl __iomem *ctrl)
> * pipeline to a depth of 1 (from it's default of 4) to preclude this situation
> * from occurring.
> */
> -static void handle_imx6_err005766(u32 *mcr)
> +static void handle_imx6_err005766(u32 __iomem *mcr)
> {
> if (of_machine_is_compatible("fsl,imx6q") ||
> of_machine_is_compatible("fsl,imx6dl") ||
>