2023-05-18 14:16:14

by Anusha Canchi

Subject: [PATCH V3 4/4] arm64: dts: qcom: ipq9574: Enable crypto nodes

Enable crypto support for ipq9574.

Signed-off-by: Anusha Rao <[email protected]>
---
Changes in V3:
- No change.

arch/arm64/boot/dts/qcom/ipq9574.dtsi | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index fea15f3cf910..6e52d35a6a15 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -123,6 +123,26 @@
clock-names = "core";
};

+ cryptobam: dma-controller@704000 {
+ compatible = "qcom,bam-v1.7.0";
+ reg = <0x00704000 0x20000>;
+ interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
+ #dma-cells = <1>;
+ qcom,ee = <1>;
+ qcom,controlled-remotely;
+ };
+
+ crypto: crypto@73a000 {
+ compatible = "qcom,ipq9574-qce", "qcom,ipq4019-qce", "qcom,qce";
+ reg = <0x0073a000 0x6000>;
+ clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
+ <&gcc GCC_CRYPTO_AXI_CLK>,
+ <&gcc GCC_CRYPTO_CLK>;
+ clock-names = "iface", "bus", "core";
+ dmas = <&cryptobam 2>, <&cryptobam 3>;
+ dma-names = "rx", "tx";
+ };
+
tlmm: pinctrl@1000000 {
compatible = "qcom,ipq9574-tlmm";
reg = <0x01000000 0x300000>;
--
2.17.1

2023-05-18 14:49:24

by Krzysztof Kozlowski

Subject: Re: [PATCH V3 4/4] arm64: dts: qcom: ipq9574: Enable crypto nodes

On 18/05/2023 16:11, Anusha Rao wrote:
> Enable crypto support for ipq9574.
>
> Signed-off-by: Anusha Rao <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-05-22 09:01:20

by Bhupesh Sharma

Subject: Re: [PATCH V3 4/4] arm64: dts: qcom: ipq9574: Enable crypto nodes

On 5/18/23 7:41 PM, Anusha Rao <[email protected]> wrote:
> Enable crypto support for ipq9574.
>
> Signed-off-by: Anusha Rao <[email protected]>
> ---
> Changes in V3:
> - No change.
>
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> index fea15f3cf910..6e52d35a6a15 100644
> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
> @@ -123,6 +123,26 @@
> clock-names = "core";
> };
>
> + cryptobam: dma-controller@704000 {
> + compatible = "qcom,bam-v1.7.0";

Please confirm if this is "qcom,bam-v1.7.4" or "qcom,bam-v1.7.0". If "qcom,bam-v1.7.4" please use the newer compatible format.

Thanks,
Bhupesh

> + reg = <0x00704000 0x20000>;
> + interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + qcom,ee = <1>;
> + qcom,controlled-remotely;
> + };
> +
> + crypto: crypto@73a000 {
> + compatible = "qcom,ipq9574-qce", "qcom,ipq4019-qce", "qcom,qce";
> + reg = <0x0073a000 0x6000>;
> + clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
> + <&gcc GCC_CRYPTO_AXI_CLK>,
> + <&gcc GCC_CRYPTO_CLK>;
> + clock-names = "iface", "bus", "core";
> + dmas = <&cryptobam 2>, <&cryptobam 3>;
> + dma-names = "rx", "tx";
> + };
> +
> tlmm: pinctrl@1000000 {
> compatible = "qcom,ipq9574-tlmm";
> reg = <0x01000000 0x300000>;
>

2023-05-24 05:30:05

by Anusha Canchi

Subject: Re: [PATCH V3 4/4] arm64: dts: qcom: ipq9574: Enable crypto nodes

On 5/22/2023 2:23 PM, [email protected] wrote:
> On 5/18/23 7:41 PM, Anusha Rao <[email protected]> wrote:
>> Enable crypto support for ipq9574.
>>
>> Signed-off-by: Anusha Rao <[email protected]>
>> ---
>>   Changes in V3:
>>     - No change.
>>
>>   arch/arm64/boot/dts/qcom/ipq9574.dtsi | 20 ++++++++++++++++++++
>>   1 file changed, 20 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> index fea15f3cf910..6e52d35a6a15 100644
>> --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
>> @@ -123,6 +123,26 @@
>>               clock-names = "core";
>>           };
>>   +        cryptobam: dma-controller@704000 {
>> +            compatible = "qcom,bam-v1.7.0";
>
> Please confirm if this is "qcom,bam-v1.7.4" or "qcom,bam-v1.7.0". If
> "qcom,bam-v1.7.4" please use the newer compatible format.
Sure, will update.

Thanks,
Anusha
>
> Thanks,
> Bhupesh
>
>> +            reg = <0x00704000 0x20000>;
>> +            interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
>> +            #dma-cells = <1>;
>> +            qcom,ee = <1>;
>> +            qcom,controlled-remotely;
>> +        };
>> +
>> +        crypto: crypto@73a000 {
>> +            compatible = "qcom,ipq9574-qce", "qcom,ipq4019-qce",
>> "qcom,qce";
>> +            reg = <0x0073a000 0x6000>;
>> +            clocks = <&gcc GCC_CRYPTO_AHB_CLK>,
>> +                 <&gcc GCC_CRYPTO_AXI_CLK>,
>> +                 <&gcc GCC_CRYPTO_CLK>;
>> +            clock-names = "iface", "bus", "core";
>> +            dmas = <&cryptobam 2>, <&cryptobam 3>;
>> +            dma-names = "rx", "tx";
>> +        };
>> +
>>           tlmm: pinctrl@1000000 {
>>               compatible = "qcom,ipq9574-tlmm";
>>               reg = <0x01000000 0x300000>;
>>