2013-11-18 04:20:03

by Michael Neuling

Subject: [PATCH] crypto: caam - Add missing Job Ring include

linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
giving:

drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function 'of_iomap' [-Werror=implicit-function-declaration]

In:
commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
Author: Ruchika Gupta <[email protected]>
crypto: caam - Add Platform driver for Job Ring

We added a reference to of_iomap but did add the necessary include file.

The below adds this include.

Signed-off-by: Michael Neuling <[email protected]>

diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index d23356d2..1d80bd3 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -6,6 +6,7 @@
*/

#include <linux/of_irq.h>
+#include <linux/of_address.h>

#include "compat.h"
#include "regs.h"

2013-11-19 04:17:37

by Ruchika Gupta

Subject: RE: [PATCH] crypto: caam - Add missing Job Ring include

Acked-by: Ruchika Gupta <[email protected]>

> -----Original Message-----
> From: [email protected] [mailto:linux-crypto-
> [email protected]] On Behalf Of Michael Neuling
> Sent: Monday, November 18, 2013 9:50 AM
> To: Gupta Ruchika-R66431
> Cc: Garg Vakul-B16394; Herbert Xu; [email protected];
> [email protected]
> Subject: [PATCH] crypto: caam - Add missing Job Ring include
>
> linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
> giving:
>
> drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> drivers/crypto/caam/jr.c:468:2: error: implicit declaration of function
> 'of_iomap' [-Werror=implicit-function-declaration]
>
> In:
> commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
> Author: Ruchika Gupta <[email protected]>
> crypto: caam - Add Platform driver for Job Ring
>
> We added a reference to of_iomap but did add the necessary include file.
>
> The below adds this include.
>
> Signed-off-by: Michael Neuling <[email protected]>
>
> diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> d23356d2..1d80bd3 100644
> --- a/drivers/crypto/caam/jr.c
> +++ b/drivers/crypto/caam/jr.c
> @@ -6,6 +6,7 @@
> */
>
> #include <linux/of_irq.h>
> +#include <linux/of_address.h>
>
> #include "compat.h"
> #include "regs.h"
> --
> To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
> the body of a message to [email protected] More majordomo info at
> http://vger.kernel.org/majordomo-info.html

2013-11-26 09:43:58

by Ruchika Gupta

Subject: RE: [PATCH] crypto: caam - Add missing Job Ring include

Hi Herbert,

Can you please apply this patch.

Regards,
Ruchika

> -----Original Message-----
> From: Gupta Ruchika-R66431
> Sent: Tuesday, November 19, 2013 9:47 AM
> To: 'Michael Neuling'
> Cc: Garg Vakul-B16394; Herbert Xu; [email protected];
> [email protected]
> Subject: RE: [PATCH] crypto: caam - Add missing Job Ring include
>
> Acked-by: Ruchika Gupta <[email protected]>
>
> > -----Original Message-----
> > From: [email protected] [mailto:linux-crypto-
> > [email protected]] On Behalf Of Michael Neuling
> > Sent: Monday, November 18, 2013 9:50 AM
> > To: Gupta Ruchika-R66431
> > Cc: Garg Vakul-B16394; Herbert Xu; [email protected];
> > [email protected]
> > Subject: [PATCH] crypto: caam - Add missing Job Ring include
> >
> > linuxnext currently doesn't compile with the powerpc mpc85xx_defconfig
> > giving:
> >
> > drivers/crypto/caam/jr.c: In function 'caam_jr_probe':
> > drivers/crypto/caam/jr.c:468:2: error: implicit declaration of
> > function 'of_iomap' [-Werror=implicit-function-declaration]
> >
> > In:
> > commit 313ea293e9c4d1eabcaddd2c0800f083b03c2a2e
> > Author: Ruchika Gupta <[email protected]>
> > crypto: caam - Add Platform driver for Job Ring
> >
> > We added a reference to of_iomap but did add the necessary include file.
> >
> > The below adds this include.
> >
> > Signed-off-by: Michael Neuling <[email protected]>
> >
> > diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c index
> > d23356d2..1d80bd3 100644
> > --- a/drivers/crypto/caam/jr.c
> > +++ b/drivers/crypto/caam/jr.c
> > @@ -6,6 +6,7 @@
> > */
> >
> > #include <linux/of_irq.h>
> > +#include <linux/of_address.h>
> >
> > #include "compat.h"
> > #include "regs.h"
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-crypto" in the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html

2013-11-26 12:59:53

by Herbert Xu

Subject: Re: [PATCH] crypto: caam - Add missing Job Ring include

On Tue, Nov 19, 2013 at 04:17:31AM +0000, Ruchika Gupta wrote:
> Acked-by: Ruchika Gupta <[email protected]>

Patch applied to crypto.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt