2021-11-01 16:31:58

by Marc Orr

[permalink] [raw]
Subject: Re: [PATCH 0/4] Add SEV_INIT_EX support

On Thu, Oct 28, 2021 at 10:57 AM Peter Gonda <[email protected]> wrote:
>
> SEV_INIT requires users to unlock their SPI bus for the PSP's non
> volatile (NV) storage. Users may wish to lock their SPI bus for numerous
> reasons, to support this the PSP firmware supports SEV_INIT_EX. INIT_EX
> allows the firmware to use a region of memory for its NV storage leaving
> the kernel responsible for actually storing the data in a persistent
> way. This series adds a new module parameter to ccp allowing users to
> specify a path to a file for use as the PSP's NV storage. The ccp driver
> then reads the file into memory for the PSP to use and is responsible
> for writing the file whenever the PSP modifies the memory region.
>
> Signed-off-by: Peter Gonda <[email protected]>
> Acked-by: David Rientjes <[email protected]>
> Cc: Tom Lendacky <[email protected]>
> Cc: Brijesh Singh <[email protected]>
> Cc: Marc Orr <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: David Rientjes <[email protected]>
> Cc: John Allen <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Paolo Bonzini <[email protected]> (
> Cc: [email protected]
> Cc: [email protected]
>
> David Rientjes (1):
> crypto: ccp - Add SEV_INIT_EX support
>
> Peter Gonda (3):
> crypto: ccp - Fix SEV_INIT error logging on init
> crypto: ccp - Move SEV_INIT retry for corrupted data
> crypto: ccp - Refactor out sev_fw_alloc()
>
> drivers/crypto/ccp/sev-dev.c | 235 ++++++++++++++++++++++++++++++-----
> include/linux/psp-sev.h | 21 ++++
> 2 files changed, 222 insertions(+), 34 deletions(-)
>
> --
> 2.33.1.1089.g2158813163f-goog
>

I've just replied with my Reviewed-by tag to all of the patches
because I had reviewed the v1 internally, before Peter posted
externally. Thank you, Tom, for the excellent reviews! I'm looking
forward to seeing the v2 with all of this feedback incorporated.