2017-09-07 14:15:12

by Srishti Sharma

Subject: [PATCH v2] Staging: ccree: Prefer using BIT macro.

Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.

Signed-off-by: Srishti Sharma <[email protected]>
---
Changes in v2:
- Add tab spaces before BIT macro.

drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/ccree/ssi_cipher.h b/drivers/staging/ccree/ssi_cipher.h
index 296b375..c9a83df 100644
--- a/drivers/staging/ccree/ssi_cipher.h
+++ b/drivers/staging/ccree/ssi_cipher.h
@@ -27,11 +27,11 @@
#include "ssi_buffer_mgr.h"

/* Crypto cipher flags */
-#define CC_CRYPTO_CIPHER_KEY_KFDE0 (1 << 0)
-#define CC_CRYPTO_CIPHER_KEY_KFDE1 (1 << 1)
-#define CC_CRYPTO_CIPHER_KEY_KFDE2 (1 << 2)
-#define CC_CRYPTO_CIPHER_KEY_KFDE3 (1 << 3)
-#define CC_CRYPTO_CIPHER_DU_SIZE_512B (1 << 4)
+#define CC_CRYPTO_CIPHER_KEY_KFDE0 BIT(0)
+#define CC_CRYPTO_CIPHER_KEY_KFDE1 BIT(1)
+#define CC_CRYPTO_CIPHER_KEY_KFDE2 BIT(2)
+#define CC_CRYPTO_CIPHER_KEY_KFDE3 BIT(3)
+#define CC_CRYPTO_CIPHER_DU_SIZE_512B BIT(4)

#define CC_CRYPTO_CIPHER_KEY_KFDE_MASK (CC_CRYPTO_CIPHER_KEY_KFDE0 | CC_CRYPTO_CIPHER_KEY_KFDE1 | CC_CRYPTO_CIPHER_KEY_KFDE2 | CC_CRYPTO_CIPHER_KEY_KFDE3)

2017-09-11 16:24:58

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.

On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
>
> Signed-off-by: Srishti Sharma <[email protected]>
> ---
> Changes in v2:
> - Add tab spaces before BIT macro.
>
> drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

This change is already in my tree from someone else, sorry.

greg k-h

2017-09-11 17:17:57

by Srishti Sharma

Subject: Re: [PATCH v2] Staging: ccree: Prefer using BIT macro.

On Mon, Sep 11, 2017 at 9:54 PM, Greg KH <[email protected]> wrote:
> On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
>> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
>>
>> Signed-off-by: Srishti Sharma <[email protected]>
>> ---
>> Changes in v2:
>> - Add tab spaces before BIT macro.
>>
>> drivers/staging/ccree/ssi_cipher.h | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> This change is already in my tree from someone else, sorry.
Oh.. It's okay !

Thanks,
Srishti
>
> greg k-h