2021-02-02 21:00:37

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

Running 'dt-validate -m' will flag any compatible strings missing a schema.
Fix all the errors found in DT binding examples. Most of these are just
typos.

Cc: Stephen Boyd <[email protected]>
Cc: Maxime Ripard <[email protected]>
Cc: Chen-Yu Tsai <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: "David S. Miller" <[email protected]>
Cc: Daniel Palmer <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: Avi Fishman <[email protected]>
Cc: Tomer Maimon <[email protected]>
Cc: Tali Perry <[email protected]>
Cc: Joerg Roedel <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Andrew Jeffery <[email protected]>
Cc: Joel Stanley <[email protected]>
Cc: Wim Van Sebroeck <[email protected]>
Cc: Guenter Roeck <[email protected]>
Cc: Yoshihiro Shimoda <[email protected]>
Cc: Vincent Cheng <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Rob Herring <[email protected]>
---
.../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
.../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
.../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
.../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
11 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
index fa0ee03a527f..53cc6df0df96 100644
--- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
+++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
@@ -18,7 +18,7 @@ properties:
const: 1

compatible:
- const: allwinner,sun9i-a80-usb-clocks
+ const: allwinner,sun9i-a80-usb-clks

reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
index eb241587efd1..118c5543e037 100644
--- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
+++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
@@ -66,8 +66,8 @@ properties:
- arm,syscon-icst525-integratorcp-cm-mem
- arm,integrator-cm-auxosc
- arm,versatile-cm-auxosc
- - arm,impd-vco1
- - arm,impd-vco2
+ - arm,impd1-vco1
+ - arm,impd1-vco2

clocks:
description: Parent clock for the ICST VCO
diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
index 1465c9ebaf93..1d48ac712b23 100644
--- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
+++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
@@ -66,7 +66,7 @@ examples:
#include <dt-bindings/soc/ti,sci_pm_domain.h>

main_crypto: crypto@4e00000 {
- compatible = "ti,j721-sa2ul";
+ compatible = "ti,j721e-sa2ul";
reg = <0x4e00000 0x1200>;
power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
index 1f2ef408bb43..fe1e1c63ffe3 100644
--- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
+++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
@@ -46,7 +46,7 @@ examples:
#include <dt-bindings/gpio/msc313-gpio.h>

gpio: gpio@207800 {
- compatible = "mstar,msc313e-gpio";
+ compatible = "mstar,msc313-gpio";
#gpio-cells = <2>;
reg = <0x207800 0x200>;
gpio-controller;
diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
index e3ef2d36f372..128444942aec 100644
--- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
+++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
@@ -17,7 +17,7 @@ maintainers:

properties:
compatible:
- const: nuvoton,npcm7xx-i2c
+ const: nuvoton,npcm750-i2c

reg:
maxItems: 1
diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
index cde1afa8dfd6..349633108bbd 100644
--- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
+++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
@@ -93,7 +93,7 @@ examples:
#include <dt-bindings/power/r8a7791-sysc.h>

ipmmu_mx: iommu@fe951000 {
- compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
+ compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
reg = <0xfe951000 0x1000>;
interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
index 54631dc1adb0..5dbb84049ff6 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
@@ -63,7 +63,7 @@ examples:
reg = <0x1e6e2000 0x1a8>;

pinctrl: pinctrl {
- compatible = "aspeed,g4-pinctrl";
+ compatible = "aspeed,ast2400-pinctrl";

pinctrl_i2c3_default: i2c3_default {
function = "I2C3";
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
index a90c0fe0495f..ad1c33364b38 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
@@ -81,7 +81,7 @@ examples:
reg = <0x1e6e2000 0x1a8>;

pinctrl: pinctrl {
- compatible = "aspeed,g5-pinctrl";
+ compatible = "aspeed,ast2500-pinctrl";
aspeed,external-nodes = <&gfx>, <&lhc>;

pinctrl_i2c3_default: i2c3_default {
diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
index c78ab7e2eee7..ad91c0bc54da 100644
--- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
@@ -95,7 +95,7 @@ examples:
reg = <0x1e6e2000 0xf6c>;

pinctrl: pinctrl {
- compatible = "aspeed,g6-pinctrl";
+ compatible = "aspeed,ast2600-pinctrl";

pinctrl_pwm10g1_default: pwm10g1_default {
function = "PWM10";
diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
index 239b49fad805..658cec67743e 100644
--- a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
+++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
@@ -59,9 +59,7 @@ additionalProperties: false

examples:
- |
- i2c@1 {
- compatible = "abc,acme-1234";
- reg = <0x01 0x400>;
+ i2c {
#address-cells = <1>;
#size-cells = <0>;
phc@5b {
diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
index c1348db59374..054584d7543a 100644
--- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
@@ -57,8 +57,8 @@ examples:
*/
#include <dt-bindings/soc/ti,sci_pm_domain.h>

- watchdog0: rti@2200000 {
- compatible = "ti,rti-wdt";
+ watchdog@2200000 {
+ compatible = "ti,j7-rti-wdt";
reg = <0x2200000 0x100>;
clocks = <&k3_clks 252 1>;
power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
--
2.27.0


2021-02-02 21:07:32

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

On 2/2/21 12:55 PM, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Daniel Palmer <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: Avi Fishman <[email protected]>
> Cc: Tomer Maimon <[email protected]>
> Cc: Tali Perry <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Joel Stanley <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Yoshihiro Shimoda <[email protected]>
> Cc: Vincent Cheng <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]

Reviewed-by: Guenter Roeck <[email protected]>

> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> --- a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";
>
> pinctrl_pwm10g1_default: pwm10g1_default {
> function = "PWM10";
> diff --git a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> index 239b49fad805..658cec67743e 100644
> --- a/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> +++ b/Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml
> @@ -59,9 +59,7 @@ additionalProperties: false
>
> examples:
> - |
> - i2c@1 {
> - compatible = "abc,acme-1234";
> - reg = <0x01 0x400>;
> + i2c {
> #address-cells = <1>;
> #size-cells = <0>;
> phc@5b {
> diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> index c1348db59374..054584d7543a 100644
> --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml
> @@ -57,8 +57,8 @@ examples:
> */
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> - watchdog0: rti@2200000 {
> - compatible = "ti,rti-wdt";
> + watchdog@2200000 {
> + compatible = "ti,j7-rti-wdt";
> reg = <0x2200000 0x100>;
> clocks = <&k3_clks 252 1>;
> power-domains = <&k3_pds 252 TI_SCI_PD_EXCLUSIVE>;
>

2021-02-03 00:56:46

by Andrew Jeffery

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples



On Wed, 3 Feb 2021, at 07:25, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Daniel Palmer <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: Avi Fishman <[email protected]>
> Cc: Tomer Maimon <[email protected]>
> Cc: Tali Perry <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Joel Stanley <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Yoshihiro Shimoda <[email protected]>
> Cc: Vincent Cheng <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml | 2 +-
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 4 ++--
> Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml | 2 +-
> Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml | 2 +-
> .../devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 2 +-
> .../devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml | 2 +-
> .../devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml | 2 +-
> Documentation/devicetree/bindings/ptp/ptp-idtcm.yaml | 4 +---
> Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml | 4 ++--
> 11 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> index fa0ee03a527f..53cc6df0df96 100644
> ---
> a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> +++
> b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> @@ -18,7 +18,7 @@ properties:
> const: 1
>
> compatible:
> - const: allwinner,sun9i-a80-usb-clocks
> + const: allwinner,sun9i-a80-usb-clks
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index eb241587efd1..118c5543e037 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -66,8 +66,8 @@ properties:
> - arm,syscon-icst525-integratorcp-cm-mem
> - arm,integrator-cm-auxosc
> - arm,versatile-cm-auxosc
> - - arm,impd-vco1
> - - arm,impd-vco2
> + - arm,impd1-vco1
> + - arm,impd1-vco2
>
> clocks:
> description: Parent clock for the ICST VCO
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> index 1465c9ebaf93..1d48ac712b23 100644
> --- a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -66,7 +66,7 @@ examples:
> #include <dt-bindings/soc/ti,sci_pm_domain.h>
>
> main_crypto: crypto@4e00000 {
> - compatible = "ti,j721-sa2ul";
> + compatible = "ti,j721e-sa2ul";
> reg = <0x4e00000 0x1200>;
> power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> diff --git
> a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;
> diff --git
> a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> index e3ef2d36f372..128444942aec 100644
> --- a/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> +++ b/Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml
> @@ -17,7 +17,7 @@ maintainers:
>
> properties:
> compatible:
> - const: nuvoton,npcm7xx-i2c
> + const: nuvoton,npcm750-i2c
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";
> reg = <0xfe951000 0x1000>;
> interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 221 IRQ_TYPE_LEVEL_HIGH>;
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> index 54631dc1adb0..5dbb84049ff6 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2400-pinctrl.yaml
> @@ -63,7 +63,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g4-pinctrl";
> + compatible = "aspeed,ast2400-pinctrl";
>
> pinctrl_i2c3_default: i2c3_default {
> function = "I2C3";
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> index a90c0fe0495f..ad1c33364b38 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2500-pinctrl.yaml
> @@ -81,7 +81,7 @@ examples:
> reg = <0x1e6e2000 0x1a8>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g5-pinctrl";
> + compatible = "aspeed,ast2500-pinctrl";
> aspeed,external-nodes = <&gfx>, <&lhc>;
>
> pinctrl_i2c3_default: i2c3_default {
> diff --git
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> index c78ab7e2eee7..ad91c0bc54da 100644
> ---
> a/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> +++
> b/Documentation/devicetree/bindings/pinctrl/aspeed,ast2600-pinctrl.yaml
> @@ -95,7 +95,7 @@ examples:
> reg = <0x1e6e2000 0xf6c>;
>
> pinctrl: pinctrl {
> - compatible = "aspeed,g6-pinctrl";
> + compatible = "aspeed,ast2600-pinctrl";

Ah, thanks. For the Aspeed changes:

Reviewed-by: Andrew Jeffery <[email protected]>

2021-02-03 08:23:53

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > index fa0ee03a527f..53cc6df0df96 100644
> > --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > @@ -18,7 +18,7 @@ properties:
> > const: 1
> >
> > compatible:
> > - const: allwinner,sun9i-a80-usb-clocks
> > + const: allwinner,sun9i-a80-usb-clks
>
> Should the file name change too?

Ideally yes, and with that change
Acked-by: Maxime Ripard <[email protected]>

Maxime


Attachments:
(No filename) (813.00 B)
signature.asc (235.00 B)
Download all attachments

2021-02-03 09:37:51

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

On Tue, Feb 2, 2021 at 9:55 PM Rob Herring <[email protected]> wrote:

> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Daniel Palmer <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: Avi Fishman <[email protected]>
> Cc: Tomer Maimon <[email protected]>
> Cc: Tali Perry <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Joel Stanley <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Yoshihiro Shimoda <[email protected]>
> Cc: Vincent Cheng <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>

Ooops.
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-02-03 09:50:24

by Daniel Palmer

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

Hi Rob,

On Wed, 3 Feb 2021 at 05:55, Rob Herring <[email protected]> wrote:
> diff --git a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> index 1f2ef408bb43..fe1e1c63ffe3 100644
> --- a/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/mstar,msc313-gpio.yaml
> @@ -46,7 +46,7 @@ examples:
> #include <dt-bindings/gpio/msc313-gpio.h>
>
> gpio: gpio@207800 {
> - compatible = "mstar,msc313e-gpio";
> + compatible = "mstar,msc313-gpio";
> #gpio-cells = <2>;
> reg = <0x207800 0x200>;
> gpio-controller;

This is correct. The compatible string dropped the e at some point and
I must have missed the example.
Thanks for the fix.

Reviewed-by: Daniel Palmer <[email protected]>

2021-02-03 21:12:33

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

On Tue, Feb 02, 2021 at 04:33:56PM -0800, Stephen Boyd wrote:
> Quoting Rob Herring (2021-02-02 12:55:42)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > index fa0ee03a527f..53cc6df0df96 100644
> > --- a/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > +++ b/Documentation/devicetree/bindings/clock/allwinner,sun9i-a80-usb-clocks.yaml
> > @@ -18,7 +18,7 @@ properties:
> > const: 1
> >
> > compatible:
> > - const: allwinner,sun9i-a80-usb-clocks
> > + const: allwinner,sun9i-a80-usb-clks
>
> Should the file name change too?

Yes, I'll fix that while applying.

Rob

2021-02-04 00:50:16

by Yoshihiro Shimoda

[permalink] [raw]
Subject: RE: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

Hi Rob,

> From: Rob Herring, Sent: Wednesday, February 3, 2021 5:56 AM
>
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Daniel Palmer <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: Avi Fishman <[email protected]>
> Cc: Tomer Maimon <[email protected]>
> Cc: Tali Perry <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Joel Stanley <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Yoshihiro Shimoda <[email protected]>
> Cc: Vincent Cheng <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>
<snip>
> diff --git a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> index cde1afa8dfd6..349633108bbd 100644
> --- a/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> +++ b/Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.yaml
> @@ -93,7 +93,7 @@ examples:
> #include <dt-bindings/power/r8a7791-sysc.h>
>
> ipmmu_mx: iommu@fe951000 {
> - compatible = "renasas,ipmmu-r8a7791", "renasas,ipmmu-vmsa";
> + compatible = "renesas,ipmmu-r8a7791", "renesas,ipmmu-vmsa";

Oops. Thank you for fixing this.

Reviewed-by: Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

2021-02-06 03:32:40

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH 1/3] dt-bindings: Fix undocumented compatible strings in examples

On Tue, Feb 02, 2021 at 02:55:42PM -0600, Rob Herring wrote:
> Running 'dt-validate -m' will flag any compatible strings missing a schema.
> Fix all the errors found in DT binding examples. Most of these are just
> typos.
>
> Cc: Stephen Boyd <[email protected]>
> Cc: Maxime Ripard <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Daniel Palmer <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: Avi Fishman <[email protected]>
> Cc: Tomer Maimon <[email protected]>
> Cc: Tali Perry <[email protected]>
> Cc: Joerg Roedel <[email protected]>
> Cc: Will Deacon <[email protected]>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Joel Stanley <[email protected]>
> Cc: Wim Van Sebroeck <[email protected]>
> Cc: Guenter Roeck <[email protected]>
> Cc: Yoshihiro Shimoda <[email protected]>
> Cc: Vincent Cheng <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Wolfram Sang <[email protected]> # for I2C


Attachments:
(No filename) (1.35 kB)
signature.asc (849.00 B)
Download all attachments