2019-07-31 13:07:07

by Iuliana Prodan

Subject: [PATCH v3 0/2] crypto: validate inputs for gcm and aes

Added inline helper functions to check authsize and assoclen for
gcm, rfc4106 and rfc4543.
Added, also, inline helper function to check key length for AES algorithms.
These are used in the generic implementation of gcm/rfc4106/rfc4543
and aes.

Changes since v2:
- rename aes helper functions without crypto_ prefix;
- change include for gcm.h.

Iuliana Prodan (2):
crypto: gcm - helper functions for assoclen/authsize check
crypto: aes - helper function to validate key length for AES
algorithms

crypto/gcm.c | 41 ++++++++++++++-------------------------
include/crypto/aes.h | 17 ++++++++++++++++
include/crypto/gcm.h | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++
lib/crypto/aes.c | 8 ++++----
4 files changed, 91 insertions(+), 30 deletions(-)

--
2.1.0

2019-07-31 15:09:45

by Horia Geanta

Subject: Re: [PATCH v3 0/2] crypto: validate inputs for gcm and aes

On 7/31/2019 4:06 PM, Iuliana Prodan wrote:
> Added inline helper functions to check authsize and assoclen for
> gcm, rfc4106 and rfc4543.
> Added, also, inline helper function to check key length for AES algorithms.
> These are used in the generic implementation of gcm/rfc4106/rfc4543
> and aes.
>
For the series:
Reviewed-by: Horia Geant? <[email protected]>

Thanks,
Horia

2019-08-01 07:40:10

by Ard Biesheuvel

Subject: Re: [PATCH v3 0/2] crypto: validate inputs for gcm and aes

On Wed, 31 Jul 2019 at 16:35, Horia Geanta <[email protected]> wrote:
>
> On 7/31/2019 4:06 PM, Iuliana Prodan wrote:
> > Added inline helper functions to check authsize and assoclen for
> > gcm, rfc4106 and rfc4543.
> > Added, also, inline helper function to check key length for AES algorithms.
> > These are used in the generic implementation of gcm/rfc4106/rfc4543
> > and aes.
> >
> For the series:
> Reviewed-by: Horia Geantă <[email protected]>
>

Likewise,

Reviewed-by: Ard Biesheuvel <[email protected]>

2019-08-09 06:19:23

by Herbert Xu

Subject: Re: [PATCH v3 0/2] crypto: validate inputs for gcm and aes

On Wed, Jul 31, 2019 at 04:05:53PM +0300, Iuliana Prodan wrote:
> Added inline helper functions to check authsize and assoclen for
> gcm, rfc4106 and rfc4543.
> Added, also, inline helper function to check key length for AES algorithms.
> These are used in the generic implementation of gcm/rfc4106/rfc4543
> and aes.
>
> Changes since v2:
> - rename aes helper functions without crypto_ prefix;
> - change include for gcm.h.
>
> Iuliana Prodan (2):
> crypto: gcm - helper functions for assoclen/authsize check
> crypto: aes - helper function to validate key length for AES
> algorithms
>
> crypto/gcm.c | 41 ++++++++++++++-------------------------
> include/crypto/aes.h | 17 ++++++++++++++++
> include/crypto/gcm.h | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> lib/crypto/aes.c | 8 ++++----
> 4 files changed, 91 insertions(+), 30 deletions(-)

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt