2019-11-17 02:55:14

by Eric Biggers

[permalink] [raw]
Subject: [PATCH] crypto: mips/chacha - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

From: Eric Biggers <[email protected]>

Another instance of CRYPTO_BLKCIPHER made it in just after it was
renamed to CRYPTO_SKCIPHER. Fix it.

Signed-off-by: Eric Biggers <[email protected]>
---
crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 472c2ad36063..5575d48473bd 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -1487,7 +1487,7 @@ config CRYPTO_CHACHA20_X86_64
config CRYPTO_CHACHA_MIPS
tristate "ChaCha stream cipher algorithms (MIPS 32r2 optimized)"
depends on CPU_MIPS32_R2
- select CRYPTO_BLKCIPHER
+ select CRYPTO_SKCIPHER
select CRYPTO_ARCH_HAVE_LIB_CHACHA

config CRYPTO_SEED
--
2.24.0


2019-11-17 08:03:07

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: [PATCH] crypto: mips/chacha - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

On Sun, 17 Nov 2019 at 03:54, Eric Biggers <[email protected]> wrote:
>
> From: Eric Biggers <[email protected]>
>
> Another instance of CRYPTO_BLKCIPHER made it in just after it was
> renamed to CRYPTO_SKCIPHER. Fix it.
>
> Signed-off-by: Eric Biggers <[email protected]>

Thanks Eric

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 472c2ad36063..5575d48473bd 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -1487,7 +1487,7 @@ config CRYPTO_CHACHA20_X86_64
> config CRYPTO_CHACHA_MIPS
> tristate "ChaCha stream cipher algorithms (MIPS 32r2 optimized)"
> depends on CPU_MIPS32_R2
> - select CRYPTO_BLKCIPHER
> + select CRYPTO_SKCIPHER
> select CRYPTO_ARCH_HAVE_LIB_CHACHA
>
> config CRYPTO_SEED
> --
> 2.24.0
>

2019-11-22 11:11:58

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: mips/chacha - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

On Sat, Nov 16, 2019 at 06:53:24PM -0800, Eric Biggers wrote:
> From: Eric Biggers <[email protected]>
>
> Another instance of CRYPTO_BLKCIPHER made it in just after it was
> renamed to CRYPTO_SKCIPHER. Fix it.
>
> Signed-off-by: Eric Biggers <[email protected]>
> ---
> crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt