Subject: [PATCH] hw_random: Include device.h instead of declaring struct device

Include linux/device.h instead of declaring struct device.

Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
---
include/linux/hw_random.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/include/linux/hw_random.h b/include/linux/hw_random.h
index bee0827..2ec9af7 100644
--- a/include/linux/hw_random.h
+++ b/include/linux/hw_random.h
@@ -13,6 +13,7 @@
#define LINUX_HWRANDOM_H_

#include <linux/completion.h>
+#include <linux/device.h>
#include <linux/types.h>
#include <linux/list.h>
#include <linux/kref.h>
@@ -51,8 +52,6 @@ struct hwrng {
struct completion cleanup_done;
};

-struct device;
-
/** Register a new Hardware Random Number Generator driver. */
extern int hwrng_register(struct hwrng *rng);
extern int devm_hwrng_register(struct device *dev, struct hwrng *rng);
--
2.10.0


2017-10-30 06:52:43

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] hw_random: Include device.h instead of declaring struct device

On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote:
> Include linux/device.h instead of declaring struct device.
>
> Signed-off-by: PrasannaKumar Muralidharan <[email protected]>

Nack. We should not include a header file when a simple forward
declaration is enough.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Subject: Re: [PATCH] hw_random: Include device.h instead of declaring struct device

Hi Herbert,

On 30 October 2017 at 12:22, Herbert Xu <[email protected]> wrote:
> On Thu, Oct 26, 2017 at 07:12:08PM +0530, PrasannaKumar Muralidharan wrote:
>> Include linux/device.h instead of declaring struct device.
>>
>> Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
>
> Nack. We should not include a header file when a simple forward
> declaration is enough.

No issues.

Regards,
PrasannaKumar