Subject: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

Samsung exynos PRNG driver is using crypto framework instead of
hw_random framework. So move the devicetree binding to crypto folder.

Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
---
Changes in v2:
* Modify MAINTAINERS file to reflect file rename

.../devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt | 0
MAINTAINERS | 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename Documentation/devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt (100%)

diff --git a/Documentation/devicetree/bindings/rng/samsung,exynos-rng4.txt b/Documentation/devicetree/bindings/crypto/samsung,exynos-rng4.txt
similarity index 100%
rename from Documentation/devicetree/bindings/rng/samsung,exynos-rng4.txt
rename to Documentation/devicetree/bindings/crypto/samsung,exynos-rng4.txt
diff --git a/MAINTAINERS b/MAINTAINERS
index 4d284c7..3e0b822 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11500,7 +11500,7 @@ L: [email protected]
L: [email protected]
S: Maintained
F: drivers/crypto/exynos-rng.c
-F: Documentation/devicetree/bindings/rng/samsung,exynos-rng4.txt
+F: Documentation/devicetree/bindings/crypto/samsung,exynos-rng4.txt

SAMSUNG FRAMEBUFFER DRIVER
M: Jingoo Han <[email protected]>
--
2.10.0


2017-08-23 16:12:09

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

On Wed, Aug 23, 2017 at 08:34:43PM +0530, PrasannaKumar Muralidharan wrote:
> Samsung exynos PRNG driver is using crypto framework instead of
> hw_random framework. So move the devicetree binding to crypto folder.
>
> Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
> ---
> Changes in v2:
> * Modify MAINTAINERS file to reflect file rename
>
> .../devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt | 0
> MAINTAINERS | 2 +-
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename Documentation/devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt (100%)
>

Patch is okay but CC list is still incomplete. I do not know how you
could get Mauro for this patch... just use get_maintainers.pl.

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Subject: Re: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

Hi Krzysztof,

On 23 August 2017 at 21:42, Krzysztof Kozlowski <[email protected]> wrote:
> On Wed, Aug 23, 2017 at 08:34:43PM +0530, PrasannaKumar Muralidharan wrote:
>> Samsung exynos PRNG driver is using crypto framework instead of
>> hw_random framework. So move the devicetree binding to crypto folder.
>>
>> Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
>> ---
>> Changes in v2:
>> * Modify MAINTAINERS file to reflect file rename
>>
>> .../devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt | 0
>> MAINTAINERS | 2 +-
>> 2 files changed, 1 insertion(+), 1 deletion(-)
>> rename Documentation/devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt (100%)
>>
>
> Patch is okay but CC list is still incomplete. I do not know how you
> could get Mauro for this patch... just use get_maintainers.pl.

I used get_maintainer.pl. Rechecked again, it says Mauro and couple of
others who may not be interested in this. It did not give your or
crypto mailing list. Its strange.

> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Thanks for the review.

> Best regards,
> Krzysztof
>

2017-08-23 16:54:58

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

On Wed, Aug 23, 2017 at 10:14:29PM +0530, PrasannaKumar Muralidharan wrote:
> Hi Krzysztof,
>
> On 23 August 2017 at 21:42, Krzysztof Kozlowski <[email protected]> wrote:
> > On Wed, Aug 23, 2017 at 08:34:43PM +0530, PrasannaKumar Muralidharan wrote:
> >> Samsung exynos PRNG driver is using crypto framework instead of
> >> hw_random framework. So move the devicetree binding to crypto folder.
> >>
> >> Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
> >> ---
> >> Changes in v2:
> >> * Modify MAINTAINERS file to reflect file rename
> >>
> >> .../devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt | 0
> >> MAINTAINERS | 2 +-
> >> 2 files changed, 1 insertion(+), 1 deletion(-)
> >> rename Documentation/devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt (100%)
> >>
> >
> > Patch is okay but CC list is still incomplete. I do not know how you
> > could get Mauro for this patch... just use get_maintainers.pl.
>
> I used get_maintainer.pl. Rechecked again, it says Mauro and couple of
> others who may not be interested in this. It did not give your or
> crypto mailing list. Its strange.

Hm, you're right. Aparently get_maintainer.pl does handle moved files
thus he printed only entries for MAINTAINERS.

You will get full entry with:
scripts/get_maintainer.pl -f Documentation/devicetree/bindings/crypto/samsung,exynos-rng4.txt

Krzysztof Kozlowski <[email protected]> (maintainer:SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (...)
Herbert Xu <[email protected]> (maintainer:CRYPTO API)
"David S. Miller" <[email protected]> (maintainer:CRYPTO API)
Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Mark Rutland <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Kukjin Kim <[email protected]> (maintainer:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES)
[email protected] (open list:SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (...)
[email protected] (open list:SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (...)
[email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
[email protected] (moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES)
[email protected] (open list)

Best regards,
Krzysztof

Subject: Re: [PATCH v2] dt/bindings: exynos-rng: Move dt binding documentation to bindings/crypto

On 23 August 2017 at 22:24, Krzysztof Kozlowski <[email protected]> wrote:
> On Wed, Aug 23, 2017 at 10:14:29PM +0530, PrasannaKumar Muralidharan wrote:
>> Hi Krzysztof,
>>
>> On 23 August 2017 at 21:42, Krzysztof Kozlowski <[email protected]> wrote:
>> > On Wed, Aug 23, 2017 at 08:34:43PM +0530, PrasannaKumar Muralidharan wrote:
>> >> Samsung exynos PRNG driver is using crypto framework instead of
>> >> hw_random framework. So move the devicetree binding to crypto folder.
>> >>
>> >> Signed-off-by: PrasannaKumar Muralidharan <[email protected]>
>> >> ---
>> >> Changes in v2:
>> >> * Modify MAINTAINERS file to reflect file rename
>> >>
>> >> .../devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt | 0
>> >> MAINTAINERS | 2 +-
>> >> 2 files changed, 1 insertion(+), 1 deletion(-)
>> >> rename Documentation/devicetree/bindings/{rng => crypto}/samsung,exynos-rng4.txt (100%)
>> >>
>> >
>> > Patch is okay but CC list is still incomplete. I do not know how you
>> > could get Mauro for this patch... just use get_maintainers.pl.
>>
>> I used get_maintainer.pl. Rechecked again, it says Mauro and couple of
>> others who may not be interested in this. It did not give your or
>> crypto mailing list. Its strange.
>
> Hm, you're right. Aparently get_maintainer.pl does handle moved files
> thus he printed only entries for MAINTAINERS.
>
> You will get full entry with:
> scripts/get_maintainer.pl -f Documentation/devicetree/bindings/crypto/samsung,exynos-rng4.txt

Will keep this in mind.

> Krzysztof Kozlowski <[email protected]> (maintainer:SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (...)
> Herbert Xu <[email protected]> (maintainer:CRYPTO API)
> "David S. Miller" <[email protected]> (maintainer:CRYPTO API)
> Rob Herring <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Mark Rutland <[email protected]> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Kukjin Kim <[email protected]> (maintainer:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES)
> [email protected] (open list:SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (...)
> [email protected] (open list:SAMSUNG EXYNOS PSEUDO RANDOM NUMBER GENERATOR (...)
> [email protected] (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> [email protected] (moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES)
> [email protected] (open list)
>
> Best regards,
> Krzysztof
>

Thanks,
PrasannaKumar