2020-07-27 11:36:52

by Fabio Estevam

Subject: Re: [PATCH 1/3] ARM: dts: imx6ull: Add rngb node

Hi Christian,

On Mon, Jul 27, 2020 at 8:00 AM Christian Eggers <[email protected]> wrote:
>
> The RNGB block on 6ull has no major differences, but it has no
> switchable clock.

Horia has already sent a patch series that adds imx6ull rngb support:
https://lkml.org/lkml/2020/7/23/173

2020-07-27 12:54:14

by Christian Eggers

Subject: [PATCH] hwrng: imx-rngc - setup default RNG quality

When hw_random device's quality is non-zero, it will automatically fill
the kernel's entropy pool at boot. For this purpose, one conservative
quality value is being picked up as the default value.

Signed-off-by: Christian Eggers <[email protected]>
---
drivers/char/hw_random/imx-rngc.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index f9c5ddd0276b..a62ff78bd7ea 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -285,6 +285,7 @@ static int imx_rngc_probe(struct platform_device *pdev)
rngc->rng.init = imx_rngc_init;
rngc->rng.read = imx_rngc_read;
rngc->rng.cleanup = imx_rngc_cleanup;
+ rngc->rng.quality = 900;

rngc->dev = &pdev->dev;
platform_set_drvdata(pdev, rngc);
--
On Mon, Jul 27, 2020 Fabian Estevam wrote:
> Horia has already sent a patch series that adds imx6ull rngb support:
> https://lkml.org/lkml/2020/7/23/173

That happens when patches are sent upstream one year after writing....

Can you please add the third patch of the series?

regards

Christian Eggers
Embedded software developer

Arnold & Richter Cine Technik GmbH & Co. Betriebs KG
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRA 57918
Persoenlich haftender Gesellschafter: Arnold & Richter Cine Technik GmbH
Sitz: Muenchen - Registergericht: Amtsgericht Muenchen - Handelsregisternummer: HRB 54477
Geschaeftsfuehrer: Dr. Michael Neuhaeuser; Stephan Schenk; Walter Trauninger; Markus Zeiler