Hi Varun,
On Sat, Apr 16, 2022 at 3:00 PM Varun Sethi <[email protected]> wrote:
>
> Hi Fabio,
> Vabhav is working on a fix for the Linux driver. He would be introducing a new property in the CAAM device tree node, which would be used for specifying the entropy delay value. This would make the solution generic. This property is optional.
Unfortunately, a devicetree property solution via optional property
would not work.
Such a solution would not be backported to stable kernels and people running old
devicetree with new kernels would still face the problem.
This problem is seen since kernel 5.10, so we need a kernel-only fix.
Thanks
On 4/16/2022 10:11 PM, Fabio Estevam wrote:
> Hi Varun,
>
> On Sat, Apr 16, 2022 at 3:00 PM Varun Sethi <[email protected]> wrote:
>>
>> Hi Fabio,
>> Vabhav is working on a fix for the Linux driver. He would be introducing a new property in the CAAM device tree node, which would be used for specifying the entropy delay value. This would make the solution generic. This property is optional.
>
> Unfortunately, a devicetree property solution via optional property
> would not work.
>
> Such a solution would not be backported to stable kernels and people running old
> devicetree with new kernels would still face the problem.
>
Indeed.
> This problem is seen since kernel 5.10, so we need a kernel-only fix.
>
I'd prefer to have this patch (or a kernel-only fix in general)
applied only on the stable kernels, and use the device tree approach
on current kernel.
However, I'm not sure this is acceptable from stable kernels rules' perspective.
The alternative is to merge this patch (btw, please add a Fixes tag)
and then the DT-based solution would also include its removal.
Horia
Hi Horia,
On Mon, Apr 18, 2022 at 9:10 AM Horia Geantă <[email protected]> wrote:
> The alternative is to merge this patch (btw, please add a Fixes tag)
> and then the DT-based solution would also include its removal.
Sounds good. I have sent a v3 with a Fixes tag.
> -----Original Message-----
> From: Fabio Estevam <[email protected]>
> Sent: Sunday, April 17, 2022 12:41 AM
> To: Varun Sethi <[email protected]>
> Cc: [email protected]; Vabhav Sharma
> <[email protected]>; Horia Geanta <[email protected]>;
> Gaurav Jain <[email protected]>; [email protected]; Fabio
> Estevam <[email protected]>
> Subject: Re: [EXT] [PATCH v2] crypto: caam - fix i.MX6SX entropy delay value
>
> Caution: EXT Email
>
> Hi Varun,
>
> On Sat, Apr 16, 2022 at 3:00 PM Varun Sethi <[email protected]> wrote:
> >
> > Hi Fabio,
> > Vabhav is working on a fix for the Linux driver. He would be introducing a
> new property in the CAAM device tree node, which would be used for
> specifying the entropy delay value. This would make the solution generic.
> This property is optional.
>
> Unfortunately, a devicetree property solution via optional property would
> not work.
>
> Such a solution would not be backported to stable kernels and people
> running old devicetree with new kernels would still face the problem.
Please elaborate and specify the version for kernel, devicetree
>
> This problem is seen since kernel 5.10, so we need a kernel-only fix.
Kernel 5.10 support devicetree, Do you mean customer using kernel without device tree?
>
> Thanks