2020-06-21 10:11:35

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH 2/3] crypto: ccree: adapt ccree essiv support to kcapi

I propose to avoid a typo in the previous patch subject.


> This patch brings the ccree essiv interface into
> compliance with kernel crypto api one.

Can an imperative wording be nicer for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=64677779e8962c20b580b471790fe42367750599#n151

Regards,
Markus


2020-06-21 11:17:26

by Gilad Ben-Yossef

[permalink] [raw]
Subject: Re: [PATCH 2/3] crypto: ccree: adapt ccree essiv support to kcapi

Hi Markus,

On Sun, Jun 21, 2020 at 1:11 PM Markus Elfring <[email protected]> wrote:
>
> I propose to avoid a typo in the previous patch subject.
>
>
> > This patch brings the ccree essiv interface into
> > compliance with kernel crypto api one.
>
> Can an imperative wording be nicer for the commit message?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=64677779e8962c20b580b471790fe42367750599#n151
>

Thank you for the review and comments for this and the previous patch.

I have taken all your suggestions into consideration and will include
them in the next revision of the patch set.

Thanks again,
Gilad

--
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!