From: Arnd Bergmann <[email protected]>
The stub function uses a different name from the normal one:
drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_c62xvf/adf_drv.c:68:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
Rename the function to match the normal one.
Fixes: 9260db6640a61 ("crypto: qat - move dbgfs init to separate file")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
index 1d64ad1a00374..e0cb2c2a2ed0b 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
@@ -22,7 +22,7 @@ static inline void adf_dbgfs_rm(struct adf_accel_dev *accel_dev)
{
}
-static inline void adf_dbgfs_cleanup(struct adf_accel_dev *accel_dev)
+static inline void adf_dbgfs_exit(struct adf_accel_dev *accel_dev)
{
}
#endif
--
2.39.2
Thanks Arnd.
I already sent the same fix a few days ago: https://patchwork.kernel.org/project/linux-crypto/patch/[email protected]/
--
Giovanni
-----Original Message-----
From: Arnd Bergmann <[email protected]>
Sent: Monday, June 5, 2023 3:45 PM
To: Cabiddu, Giovanni <[email protected]>; Herbert Xu <[email protected]>; David S. Miller <[email protected]>; Muszynski, Damian <[email protected]>
Cc: Arnd Bergmann <[email protected]>; qat-linux <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] crypto: qat - fix adf_dbgfs_exit() typo
From: Arnd Bergmann <[email protected]>
The stub function uses a different name from the normal one:
drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_dh895xcc/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_c62xvf/adf_drv.c:68:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
drivers/crypto/intel/qat/qat_c62x/adf_drv.c:69:9: error: implicit declaration of function 'adf_dbgfs_exit'; did you mean 'adf_dbgfs_init'? [-Werror=implicit-function-declaration]
Rename the function to match the normal one.
Fixes: 9260db6640a61 ("crypto: qat - move dbgfs init to separate file")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/crypto/intel/qat/qat_common/adf_dbgfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
index 1d64ad1a00374..e0cb2c2a2ed0b 100644
--- a/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
+++ b/drivers/crypto/intel/qat/qat_common/adf_dbgfs.h
@@ -22,7 +22,7 @@ static inline void adf_dbgfs_rm(struct adf_accel_dev *accel_dev) { }
-static inline void adf_dbgfs_cleanup(struct adf_accel_dev *accel_dev)
+static inline void adf_dbgfs_exit(struct adf_accel_dev *accel_dev)
{
}
#endif
--
2.39.2