On 01/06/2022 10:01, Neal Liu wrote:
>>> + clocks:
>>> + maxItems: 1
>>> +
>>> + clock-names:
>>> + maxItems: 1
>>
>> You need to list clock names, however usually it does not make sense to have
>> names for just one main device clock.
>>
> I think list clock-names is optional, I'll remove it from required list.
I actually suggest to remove the clock-names property entirely, if is
has one generic entry called "clk" (or "vclk" - the same). Do you
already expect adding here more clocks?
Best regards,
Krzysztof
> Subject: Re: [PATCH 4/5] dt-bindings: crypto: add documentation for aspeed
> hace
>
> On 01/06/2022 10:01, Neal Liu wrote:
> >>> + clocks:
> >>> + maxItems: 1
> >>> +
> >>> + clock-names:
> >>> + maxItems: 1
> >>
> >> You need to list clock names, however usually it does not make sense
> >> to have names for just one main device clock.
> >>
> > I think list clock-names is optional, I'll remove it from required list.
>
> I actually suggest to remove the clock-names property entirely, if is has one
> generic entry called "clk" (or "vclk" - the same). Do you already expect adding
> here more clocks?
>
You are right. Currently, it has only one clock. I'll remove both of them.
Thanks
>
> Best regards,
> Krzysztof