2021-12-17 09:22:47

by Heiner Kallweit

Subject: [PATCH] crypto: omap-aes: Fix broken pm_runtime_and_get() usage

This fix is basically the same as 3d6b661330a7 ("crypto: stm32 -
Revert broken pm_runtime_resume_and_get changes"), just for the omap
driver. If the return value isn't used, then pm_runtime_get_sync()
has to be used for ensuring that the usage count is balanced.

Fixes: 1f34cc4a8da3 ("crypto: omap-aes - Fix PM reference leak on omap-aes.c")
Cc: [email protected]
Signed-off-by: Heiner Kallweit <[email protected]>
---
drivers/crypto/omap-aes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index 9b968ac4e..a196bb8b1 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1302,7 +1302,7 @@ static int omap_aes_suspend(struct device *dev)

static int omap_aes_resume(struct device *dev)
{
- pm_runtime_resume_and_get(dev);
+ pm_runtime_get_sync(dev);
return 0;
}
#endif
--
2.34.1

2021-12-24 03:26:36

by Herbert Xu

Subject: Re: [PATCH] crypto: omap-aes: Fix broken pm_runtime_and_get() usage

On Fri, Dec 17, 2021 at 10:03:30AM +0100, Heiner Kallweit wrote:
> This fix is basically the same as 3d6b661330a7 ("crypto: stm32 -
> Revert broken pm_runtime_resume_and_get changes"), just for the omap
> driver. If the return value isn't used, then pm_runtime_get_sync()
> has to be used for ensuring that the usage count is balanced.
>
> Fixes: 1f34cc4a8da3 ("crypto: omap-aes - Fix PM reference leak on omap-aes.c")
> Cc: [email protected]
> Signed-off-by: Heiner Kallweit <[email protected]>
> ---
> drivers/crypto/omap-aes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt