2022-04-19 07:12:31

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the crypto tree

---

Hi all,

In commit

c690c7f6312c ("crypto: qat - rework the VF2PF interrupt handling logic")

Fixes tag

Fixes: 993161d ("crypto: qat - fix handling of VF to PF interrupts")

has these problem(s):

- SHA1 should be at least 12 digits long
This can be fixed for the future by setting core.abbrev to 12 (or
more) or (for git v2.11 or later) just making sure it is not set
(or set to "auto").

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-04-19 11:37:16

by Cabiddu, Giovanni

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the crypto tree

---

Thanks Stephen.

On Tue, Apr 19, 2022 at 07:17:22AM +1000, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> c690c7f6312c ("crypto: qat - rework the VF2PF interrupt handling logic")
>
> Fixes tag
>
> Fixes: 993161d ("crypto: qat - fix handling of VF to PF interrupts")
>
> has these problem(s):
>
> - SHA1 should be at least 12 digits long
> This can be fixed for the future by setting core.abbrev to 12 (or
> more) or (for git v2.11 or later) just making sure it is not set
> (or set to "auto").
Apologies, I missed this during the review of the patch.

@Herbert, should I resend the patch with the correct Fixes tag or can
you amend the commit in your tree.

This should be the correct tag:
Fixes: 993161d36ab5 ("crypto: qat - fix handling of VF to PF interrupts")

Regards,

--
Giovanni