2022-04-14 01:10:46

by Krzysztof Kozlowski

Subject: Re: [PATCH v5 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML

On 13/04/2022 21:07, Corentin Labbe wrote:
> Convert rockchip-crypto to YAML.

Thank you for your patch. There is something to discuss/improve.

> +properties:
> + compatible:
> + enum:
> + - rockchip,rk3288-crypto
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 4
> +
> + clock-names:
> + maxItems: 4

This is not needed and dt_bindings_check should complain.

> + items:
> + const: aclk
> + const: hclk
> + const: sclk
> + const: apb_pclk
> +
> + resets:
> + maxItems: 1
> +
> + reset-names:
> + maxItems: 1

The same.


Best regards,
Krzysztof

2022-04-21 09:21:18

by Corentin LABBE

Subject: Re: [PATCH v5 24/33] dt-bindings: crypto: convert rockchip-crypto to YAML

Le Wed, Apr 13, 2022 at 09:31:13PM +0200, Krzysztof Kozlowski a ?crit :
> On 13/04/2022 21:07, Corentin Labbe wrote:
> > Convert rockchip-crypto to YAML.
>
> Thank you for your patch. There is something to discuss/improve.
>
> > +properties:
> > + compatible:
> > + enum:
> > + - rockchip,rk3288-crypto
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 4
> > +
> > + clock-names:
> > + maxItems: 4
>
> This is not needed and dt_bindings_check should complain.
>
> > + items:
> > + const: aclk
> > + const: hclk
> > + const: sclk
> > + const: apb_pclk
> > +
> > + resets:
> > + maxItems: 1
> > +
> > + reset-names:
> > + maxItems: 1
>
> The same.
>

I forgot to test the intermediate patch...
Before I send a new version, does the final document is okay ?