2022-08-02 03:32:08

by Zhuo Chen

Subject: [PATCH RESEND] crypto: hisilicon - Remove pci_aer_clear_nonfatal_status() call

Calls to pci_cleanup_aer_uncorrect_error_status() have already been
removed after commit 62b36c3ea664 ("PCI/AER: Remove
pci_cleanup_aer_uncorrect_error_status() calls"). But in commit
6c6dd5802c2d ("crypto: hisilicon/qm - add controller reset interface")
pci_aer_clear_nonfatal_status() was used again, so remove it in
this patch.

note: pci_cleanup_aer_uncorrect_error_status() was renamed to
pci_aer_clear_nonfatal_status() in commit 894020fdd88c
("PCI/AER: Rationalize error status register clearing")

Signed-off-by: Zhuo Chen <[email protected]>
---
drivers/crypto/hisilicon/qm.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index b4ca2eb034d7..fc11e17abbfc 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -5431,8 +5431,6 @@ pci_ers_result_t hisi_qm_dev_slot_reset(struct pci_dev *pdev)
if (pdev->is_virtfn)
return PCI_ERS_RESULT_RECOVERED;

- pci_aer_clear_nonfatal_status(pdev);
-
/* reset pcie device controller */
ret = qm_controller_reset(qm);
if (ret) {
--
2.30.1 (Apple Git-130)

2022-08-19 11:04:48

by Herbert Xu

Subject: Re: [PATCH RESEND] crypto: hisilicon - Remove pci_aer_clear_nonfatal_status() call

On Tue, Aug 02, 2022 at 11:29:37AM +0800, Zhuo Chen wrote:
> Calls to pci_cleanup_aer_uncorrect_error_status() have already been
> removed after commit 62b36c3ea664 ("PCI/AER: Remove
> pci_cleanup_aer_uncorrect_error_status() calls"). But in commit
> 6c6dd5802c2d ("crypto: hisilicon/qm - add controller reset interface")
> pci_aer_clear_nonfatal_status() was used again, so remove it in
> this patch.
>
> note: pci_cleanup_aer_uncorrect_error_status() was renamed to
> pci_aer_clear_nonfatal_status() in commit 894020fdd88c
> ("PCI/AER: Rationalize error status register clearing")
>
> Signed-off-by: Zhuo Chen <[email protected]>
> ---
> drivers/crypto/hisilicon/qm.c | 2 --
> 1 file changed, 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt