2023-12-12 10:01:00

by Krzysztof Kozlowski

Subject: [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE

Binding marks several devices as compatible with IPQ4019 QCE. They have
different number of clocks, thus the fallback does not define the
clock constraints per variant and each specific compatible should have
its clocks in if:then: section.

Add missing clocks description for IPQ9574 QCE.

Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index eeb8a956d7cb..6435708da202 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -97,6 +97,7 @@ allOf:
- qcom,crypto-v5.4
- qcom,ipq6018-qce
- qcom,ipq8074-qce
+ - qcom,ipq9574-qce
- qcom,msm8996-qce
- qcom,sdm845-qce
then:
--
2.34.1

2023-12-12 10:01:03

by Krzysztof Kozlowski

Subject: [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE

All devices compatible with SM8150 QCE (so SM8250 and newer) do not have
clock inputs (clocks are handled by secure firmware), so explicitly
disallow the clocks in the bindings.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/crypto/qcom-qce.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 6435708da202..e8c418b614dc 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -131,6 +131,17 @@ allOf:
- clocks
- clock-names

+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm8150-qce
+ then:
+ properties:
+ clocks: false
+ clock-names: false
+
required:
- compatible
- reg
--
2.34.1

2023-12-14 21:40:33

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE

On Tue, 12 Dec 2023 11:00:43 +0100, Krzysztof Kozlowski wrote:
> Binding marks several devices as compatible with IPQ4019 QCE. They have
> different number of clocks, thus the fallback does not define the
> clock constraints per variant and each specific compatible should have
> its clocks in if:then: section.
>
> Add missing clocks description for IPQ9574 QCE.
>
> Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>

2023-12-14 21:40:50

by Rob Herring (Arm)

Subject: Re: [PATCH 2/2] dt-bindings: crypto: qcom-qce: constrain clocks for SM8150-compatible QCE

On Tue, 12 Dec 2023 11:00:44 +0100, Krzysztof Kozlowski wrote:
> All devices compatible with SM8150 QCE (so SM8250 and newer) do not have
> clock inputs (clocks are handled by secure firmware), so explicitly
> disallow the clocks in the bindings.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/crypto/qcom-qce.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2023-12-22 04:36:25

by Herbert Xu

Subject: Re: [PATCH 1/2] dt-bindings: crypto: qcom-qce: constrain clocks for IPQ9574 QCE

On Tue, Dec 12, 2023 at 11:00:43AM +0100, Krzysztof Kozlowski wrote:
> Binding marks several devices as compatible with IPQ4019 QCE. They have
> different number of clocks, thus the fallback does not define the
> clock constraints per variant and each specific compatible should have
> its clocks in if:then: section.
>
> Add missing clocks description for IPQ9574 QCE.
>
> Fixes: 1f5ce01d5d71 ("dt-bindings: crypto: qcom-qce: add SoC compatible string for ipq9574")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> index eeb8a956d7cb..6435708da202 100644
> --- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> +++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
> @@ -97,6 +97,7 @@ allOf:
> - qcom,crypto-v5.4
> - qcom,ipq6018-qce
> - qcom,ipq8074-qce
> + - qcom,ipq9574-qce
> - qcom,msm8996-qce
> - qcom,sdm845-qce
> then:
> --
> 2.34.1

All applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt