2024-01-21 19:55:45

by Joachim Vandersmissen

[permalink] [raw]
Subject: [PATCH] crypto: remove unused xts4096 and xts512 algorithms from testmgr.c

Commit a93492cae30a ("crypto: ccree - remove data unit size support")
removed support for the xts512 and xts4096 algorithms, but left them
defined in testmgr.c. This patch removes those definitions.

Signed-off-by: Joachim Vandersmissen <[email protected]>
---
crypto/testmgr.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index c26aeda85787..3dddd288ca02 100644
--- a/crypto/testmgr.c
+++ b/crypto/testmgr.c
@@ -5720,14 +5720,6 @@ static const struct alg_test_desc alg_test_descs[] = {
}
}, {
#endif
- .alg = "xts4096(paes)",
- .test = alg_test_null,
- .fips_allowed = 1,
- }, {
- .alg = "xts512(paes)",
- .test = alg_test_null,
- .fips_allowed = 1,
- }, {
.alg = "xxhash64",
.test = alg_test_hash,
.fips_allowed = 1,
--
2.43.0



2024-01-22 10:52:54

by Ard Biesheuvel

[permalink] [raw]
Subject: Re: [PATCH] crypto: remove unused xts4096 and xts512 algorithms from testmgr.c

On Sun, 21 Jan 2024 at 20:55, Joachim Vandersmissen <[email protected]> wrote:
>
> Commit a93492cae30a ("crypto: ccree - remove data unit size support")
> removed support for the xts512 and xts4096 algorithms, but left them
> defined in testmgr.c. This patch removes those definitions.
>
> Signed-off-by: Joachim Vandersmissen <[email protected]>

Acked-by: Ard Biesheuvel <[email protected]>

> ---
> crypto/testmgr.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/crypto/testmgr.c b/crypto/testmgr.c
> index c26aeda85787..3dddd288ca02 100644
> --- a/crypto/testmgr.c
> +++ b/crypto/testmgr.c
> @@ -5720,14 +5720,6 @@ static const struct alg_test_desc alg_test_descs[] = {
> }
> }, {
> #endif
> - .alg = "xts4096(paes)",
> - .test = alg_test_null,
> - .fips_allowed = 1,
> - }, {
> - .alg = "xts512(paes)",
> - .test = alg_test_null,
> - .fips_allowed = 1,
> - }, {
> .alg = "xxhash64",
> .test = alg_test_hash,
> .fips_allowed = 1,
> --
> 2.43.0
>
>

2024-01-26 10:00:51

by Herbert Xu

[permalink] [raw]
Subject: Re: [PATCH] crypto: remove unused xts4096 and xts512 algorithms from testmgr.c

On Sun, Jan 21, 2024 at 01:45:26PM -0600, Joachim Vandersmissen wrote:
> Commit a93492cae30a ("crypto: ccree - remove data unit size support")
> removed support for the xts512 and xts4096 algorithms, but left them
> defined in testmgr.c. This patch removes those definitions.
>
> Signed-off-by: Joachim Vandersmissen <[email protected]>
> ---
> crypto/testmgr.c | 8 --------
> 1 file changed, 8 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt