2024-06-04 20:32:01

by Sakari Ailus

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] treewide: Align match_string() with sysfs_match_string()

Hi Andy,

On Sun, Jun 02, 2024 at 06:57:12PM +0300, Andy Shevchenko wrote:
> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
> index 503773707e01..9cb350de30f0 100644
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -798,7 +798,7 @@ static bool acpi_info_matches_ids(struct acpi_device_info *info,
> if (!(info->valid & ACPI_VALID_HID))
> return false;
>
> - index = match_string(ids, -1, info->hardware_id.string);
> + index = __match_string(ids, -1, info->hardware_id.string);
> if (index >= 0)
> return true;
>
> @@ -809,7 +809,7 @@ static bool acpi_info_matches_ids(struct acpi_device_info *info,
> return false;
>
> for (i = 0; i < cid_list->count; i++) {
> - index = match_string(ids, -1, cid_list->ids[i].string);
> + index = __match_string(ids, -1, cid_list->ids[i].string);
> if (index >= 0)
> return true;
> }

Reviewed-by: Sakari Ailus <[email protected]> # drivers/acpi

--
Sakari Ailus