2017-05-26 09:43:09

by Ryder Lee

Subject: [PATCH 2/2] crypto: mediatek - update DT binding documentation

This patch removes unnecessary clock in binding file.

Signed-off-by: Ryder Lee <ryder.lee-NuS5LvNUpcJWk0Htik3J/[email protected]>
---
Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
index c204725..450da36 100644
--- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
+++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
@@ -6,8 +6,7 @@ Required properties:
- interrupts: Should contain the five crypto engines interrupts in numeric
order. These are global system and four descriptor rings.
- clocks: the clock used by the core
-- clock-names: the names of the clock listed in the clocks property. These are
- "ethif", "cryp"
+- clock-names: Must contain "cryp".
- power-domains: Must contain a reference to the PM domain.


@@ -20,8 +19,7 @@ Example:
<GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
<GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
- clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
- <&ethsys CLK_ETHSYS_CRYPTO>;
- clock-names = "ethif","cryp";
+ clocks = <&ethsys CLK_ETHSYS_CRYPTO>;
+ clock-names = "cryp";
power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
};
--
1.9.1

2017-05-26 14:15:27

by Matthias Brugger

Subject: Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

On 26/05/17 11:43, Ryder Lee wrote:
> This patch removes unnecessary clock in binding file.
>
> Signed-off-by: Ryder Lee <[email protected]>
> ---

In the driver clocks are get by name, so this change does not break
backwards compatibility.

Reviewed-by: Matthias Brugger <[email protected]>

> Documentation/devicetree/bindings/crypto/mediatek-crypto.txt | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> index c204725..450da36 100644
> --- a/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> +++ b/Documentation/devicetree/bindings/crypto/mediatek-crypto.txt
> @@ -6,8 +6,7 @@ Required properties:
> - interrupts: Should contain the five crypto engines interrupts in numeric
> order. These are global system and four descriptor rings.
> - clocks: the clock used by the core
> -- clock-names: the names of the clock listed in the clocks property. These are
> - "ethif", "cryp"
> +- clock-names: Must contain "cryp".
> - power-domains: Must contain a reference to the PM domain.
>
>
> @@ -20,8 +19,7 @@ Example:
> <GIC_SPI 84 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 91 IRQ_TYPE_LEVEL_LOW>,
> <GIC_SPI 97 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <&topckgen CLK_TOP_ETHIF_SEL>,
> - <&ethsys CLK_ETHSYS_CRYPTO>;
> - clock-names = "ethif","cryp";
> + clocks = <&ethsys CLK_ETHSYS_CRYPTO>;
> + clock-names = "cryp";
> power-domains = <&scpsys MT2701_POWER_DOMAIN_ETH>;
> };
>

2017-05-31 18:46:20

by Rob Herring

Subject: Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

On Fri, May 26, 2017 at 05:43:09PM +0800, Ryder Lee wrote:
> This patch removes unnecessary clock in binding file.

Why is the clock unnecessary? A h/w block either has a clock or doesn't.

The subject needs some work. Perhaps "dt-bindings: crypto: remove
mediatek ethif clock".

Rob

2017-06-01 01:04:45

by Ryder Lee

Subject: Re: [PATCH 2/2] crypto: mediatek - update DT binding documentation

On Wed, 2017-05-31 at 13:46 -0500, Rob Herring wrote:
> On Fri, May 26, 2017 at 05:43:09PM +0800, Ryder Lee wrote:
> > This patch removes unnecessary clock in binding file.
>
> Why is the clock unnecessary? A h/w block either has a clock or doesn't.
>
> The subject needs some work. Perhaps "dt-bindings: crypto: remove
> mediatek ethif clock".
>
> Rob

I'll write more clearly, thanks.

Ryder.