On 4/16/2024 8:35 AM, Pankaj Gupta wrote:
> CAAM clock initializat is done based on the basis of soc specific
^ initialization
> @@ -889,17 +895,25 @@ static int caam_probe(struct platform_device *pdev)
>
> reg_access = !ctrlpriv->optee_en;
>
> - if (!imx_soc_match->data) {
> + if (imx_soc_match->data) {
This is obviously incorrect.
> dev_err(dev, "No clock data provided for i.MX SoC");
> return -EINVAL;
> }
Regards,
Horia
> -----Original Message-----
> From: Horia Geanta <[email protected]>
> Sent: Thursday, April 18, 2024 8:20 PM
> To: Pankaj Gupta <[email protected]>; Gaurav Jain
> <[email protected]>; Varun Sethi <[email protected]>;
> [email protected]; [email protected]; Iuliana Prodan
> <[email protected]>; [email protected]; linux-
> [email protected]; dl-linux-imx <[email protected]>
> Subject: Re: [PATCH v3 1/2] caam: init-clk based on caam-page0-access
>
> On 4/16/2024 8:35 AM, Pankaj Gupta wrote:
> > CAAM clock initializat is done based on the basis of soc specific
> ^ initialization
>
> > @@ -889,17 +895,25 @@ static int caam_probe(struct platform_device
> *pdev)
> >
> > reg_access = !ctrlpriv->optee_en;
> >
> > - if (!imx_soc_match->data) {
> > + if (imx_soc_match->data) {
> This is obviously incorrect.
[Accepted]
>
> > dev_err(dev, "No clock data provided for i.MX SoC");
> > return -EINVAL;
> > }
>
> Regards,
> Horia