2019-10-22 08:12:05

by Yunfeng Ye

Subject: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]>
---
v2 -> v3:
- add "Acked-by:"

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..e3e27349a9fe 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
goto xts_tail;

kernel_neon_end();
- skcipher_walk_done(&walk, nbytes);
+ err = skcipher_walk_done(&walk, nbytes);
}

if (err || likely(!tail))
--
2.7.4.3

2019-10-31 07:04:04

by Yunfeng Ye

Subject: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

A warning is found by the static code analysis tool:
"Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]>
---
v2 -> v3:
- add "Acked-by:"

v1 -> v2:
- update the subject and comment
- add return value of skcipher_walk_done()

arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
index ea873b8904c4..e3e27349a9fe 100644
--- a/arch/arm64/crypto/aes-neonbs-glue.c
+++ b/arch/arm64/crypto/aes-neonbs-glue.c
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
goto xts_tail;

kernel_neon_end();
- skcipher_walk_done(&walk, nbytes);
+ err = skcipher_walk_done(&walk, nbytes);
}

if (err || likely(!tail))
--
2.7.4.3

2019-10-31 08:14:17

by Ard Biesheuvel

Subject: Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

On Thu, 31 Oct 2019 at 08:02, Yunfeng Ye <[email protected]> wrote:
>
> A warning is found by the static code analysis tool:
> "Identical condition 'err', second condition is always false"
>
> Fix this by adding return value of skcipher_walk_done().
>
> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
> Signed-off-by: Yunfeng Ye <[email protected]>
> Acked-by: Ard Biesheuvel <[email protected]>

Please don't send the exact same patch twice, and when you feel the
need to do so, just ask instead whether your patch was received or
not.

I'm sure Herbert will pick it up shortly.

> ---
> v2 -> v3:
> - add "Acked-by:"
>
> v1 -> v2:
> - update the subject and comment
> - add return value of skcipher_walk_done()
>
> arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/aes-neonbs-glue.c b/arch/arm64/crypto/aes-neonbs-glue.c
> index ea873b8904c4..e3e27349a9fe 100644
> --- a/arch/arm64/crypto/aes-neonbs-glue.c
> +++ b/arch/arm64/crypto/aes-neonbs-glue.c
> @@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
> goto xts_tail;
>
> kernel_neon_end();
> - skcipher_walk_done(&walk, nbytes);
> + err = skcipher_walk_done(&walk, nbytes);
> }
>
> if (err || likely(!tail))
> --
> 2.7.4.3
>
>

2019-11-01 06:10:43

by Herbert Xu

Subject: Re: [PATCH v3] crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()

On Tue, Oct 22, 2019 at 04:11:18PM +0800, Yunfeng Ye wrote:
> A warning is found by the static code analysis tool:
> "Identical condition 'err', second condition is always false"
>
> Fix this by adding return value of skcipher_walk_done().
>
> Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
> Signed-off-by: Yunfeng Ye <[email protected]>
> Acked-by: Ard Biesheuvel <[email protected]>
> ---
> v2 -> v3:
> - add "Acked-by:"
>
> v1 -> v2:
> - update the subject and comment
> - add return value of skcipher_walk_done()
>
> arch/arm64/crypto/aes-neonbs-glue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt