2022-02-22 17:52:19

by Keith Busch

Subject: [PATCHv3 03/10] asm-generic: introduce be48 unaligned accessors

The NVMe protocol extended the data integrity fields with unaligned
48-bit reference tags. Provide some helper accessors in
preparation for these.

Reviewed-by: Hannes Reinecke <[email protected]>
Reviewed-by: Martin K. Petersen <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Signed-off-by: Keith Busch <[email protected]>
---
include/asm-generic/unaligned.h | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)

diff --git a/include/asm-generic/unaligned.h b/include/asm-generic/unaligned.h
index 1c4242416c9f..8fc637379899 100644
--- a/include/asm-generic/unaligned.h
+++ b/include/asm-generic/unaligned.h
@@ -126,4 +126,30 @@ static inline void put_unaligned_le24(const u32 val, void *p)
__put_unaligned_le24(val, p);
}

+static inline void __put_unaligned_be48(const u64 val, __u8 *p)
+{
+ *p++ = val >> 40;
+ *p++ = val >> 32;
+ *p++ = val >> 24;
+ *p++ = val >> 16;
+ *p++ = val >> 8;
+ *p++ = val;
+}
+
+static inline void put_unaligned_be48(const u64 val, void *p)
+{
+ __put_unaligned_be48(val, p);
+}
+
+static inline u64 __get_unaligned_be48(const u8 *p)
+{
+ return (u64)p[0] << 40 | (u64)p[1] << 32 | p[2] << 24 |
+ p[3] << 16 | p[4] << 8 | p[5];
+}
+
+static inline u64 get_unaligned_be48(const void *p)
+{
+ return __get_unaligned_be48(p);
+}
+
#endif /* __ASM_GENERIC_UNALIGNED_H */
--
2.25.4

2022-02-23 01:30:05

by Chaitanya Kulkarni

Subject: Re: [PATCHv3 03/10] asm-generic: introduce be48 unaligned accessors

On 2/22/22 08:31, Keith Busch wrote:
> The NVMe protocol extended the data integrity fields with unaligned
> 48-bit reference tags. Provide some helper accessors in
> preparation for these.
>
> Reviewed-by: Hannes Reinecke <[email protected]>
> Reviewed-by: Martin K. Petersen <[email protected]>
> Acked-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Keith Busch <[email protected]>
> ---

Looks good.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

-ck

2022-02-26 02:20:07

by Joe Perches

Subject: Re: [PATCHv3 03/10] asm-generic: introduce be48 unaligned accessors

On Fri, 2022-02-25 at 17:03 +0100, Christoph Hellwig wrote:
> On Tue, Feb 22, 2022 at 08:31:37AM -0800, Keith Busch wrote:
> > The NVMe protocol extended the data integrity fields with unaligned
> > 48-bit reference tags. Provide some helper accessors in
> > preparation for these.
> >
> > Reviewed-by: Hannes Reinecke <[email protected]>
> > Reviewed-by: Martin K. Petersen <[email protected]>
> > Acked-by: Arnd Bergmann <[email protected]>
> > Signed-off-by: Keith Busch <[email protected]>
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <[email protected]>

Perhaps for completeness this should also add the le48 variants
like the 24 bit accessors above this.