2019-03-30 05:49:48

by Yue Haibing

Subject: [PATCH -next] crypto: marvell - remove set but not used variable 'index'

From: YueHaibing <[email protected]>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/crypto/marvell/hash.c: In function 'mv_cesa_ahash_pad_req':
drivers/crypto/marvell/hash.c:138:15: warning: variable 'index' set but not used [-Wunused-but-set-variable]

It's never used and can be removed.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/crypto/marvell/hash.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
index 99ff54c..fd456dd 100644
--- a/drivers/crypto/marvell/hash.c
+++ b/drivers/crypto/marvell/hash.c
@@ -135,11 +135,10 @@ static int mv_cesa_ahash_pad_len(struct mv_cesa_ahash_req *creq)

static int mv_cesa_ahash_pad_req(struct mv_cesa_ahash_req *creq, u8 *buf)
{
- unsigned int index, padlen;
+ unsigned int padlen;

buf[0] = 0x80;
/* Pad out to 56 mod 64 */
- index = creq->len & CESA_HASH_BLOCK_SIZE_MSK;
padlen = mv_cesa_ahash_pad_len(creq);
memset(buf + 1, 0, padlen - 1);

--
2.7.0

2019-03-30 10:15:18

by Mukesh Ojha

Subject: Re: [PATCH -next] crypto: marvell - remove set but not used variable 'index'

On 3/30/2019 10:58 AM, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/crypto/marvell/hash.c: In function 'mv_cesa_ahash_pad_req':
> drivers/crypto/marvell/hash.c:138:15: warning: variable 'index' set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh

> ---
> drivers/crypto/marvell/hash.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/marvell/hash.c b/drivers/crypto/marvell/hash.c
> index 99ff54c..fd456dd 100644
> --- a/drivers/crypto/marvell/hash.c
> +++ b/drivers/crypto/marvell/hash.c
> @@ -135,11 +135,10 @@ static int mv_cesa_ahash_pad_len(struct mv_cesa_ahash_req *creq)
>
> static int mv_cesa_ahash_pad_req(struct mv_cesa_ahash_req *creq, u8 *buf)
> {
> - unsigned int index, padlen;
> + unsigned int padlen;
>
> buf[0] = 0x80;
> /* Pad out to 56 mod 64 */
> - index = creq->len & CESA_HASH_BLOCK_SIZE_MSK;
> padlen = mv_cesa_ahash_pad_len(creq);
> memset(buf + 1, 0, padlen - 1);
>

2019-04-08 06:41:06

by Herbert Xu

Subject: Re: [PATCH -next] crypto: marvell - remove set but not used variable 'index'

On Sat, Mar 30, 2019 at 01:28:58PM +0800, Yue Haibing wrote:
> From: YueHaibing <[email protected]>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/crypto/marvell/hash.c: In function 'mv_cesa_ahash_pad_req':
> drivers/crypto/marvell/hash.c:138:15: warning: variable 'index' set but not used [-Wunused-but-set-variable]
>
> It's never used and can be removed.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/crypto/marvell/hash.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt