LinuxLists.cc - [PATCH v2 0/8] kobject: Add default group support to kobj

2019-04-02 02:51:23

Subject: [PATCH v2 0/8] kobject: Add default group support to kobj_type and replace subsystem uses

This patchset adds support for default attribute groups to kobj_type.
Also, the uses of kobj_type's default_attrs field are replaced with
default_groups in the following subsystems:
- samples
- block
- net
- irq
- padata
- cpufreq
- livepatch

The subsystem maintainers and lists will be copied on the subsystem
patches.

The uses of kobj_type's default_attrs field in the other subsystems will
be replaced in future patchsets.

Changes in v2:
- Patch 1 is not changed.
- Patches 2-8 are new.

Kimberly Brown (8):
kobject: Add support for default attribute groups to kobj_type
samples/kobject: Replace foo_ktype's default_attrs field with groups
block: Replace all ktype default_attrs with groups
net-sysfs: Replace ktype default_attrs field with groups
irqdesc: Replace irq_kobj_type's default_attrs field with groups
padata: Replace padata_attr_type default_attrs field with groups
cpufreq: schedutil: Replace default_attrs field with groups
livepatch: Replace klp_ktype_patch's default_attrs with groups

block/blk-integrity.c | 3 ++-
block/blk-mq-sysfs.c | 8 ++------
block/blk-sysfs.c | 3 ++-
include/linux/kobject.h | 3 ++-
kernel/irq/irqdesc.c | 3 ++-
kernel/livepatch/core.c | 3 ++-
kernel/padata.c | 3 ++-
kernel/sched/cpufreq_schedutil.c | 5 +++--
lib/kobject.c | 14 ++++++++++++++
net/core/net-sysfs.c | 6 ++++--
samples/kobject/kset-example.c | 3 ++-
11 files changed, 37 insertions(+), 17 deletions(-)

--
2.17.1

2019-04-02 02:51:52

by Kimberly Brown

[permalink] [raw]

Subject: [PATCH v2 6/8] padata: Replace padata_attr_type default_attrs field with groups

The kobj_type default_attrs field is being replaced by the
default_groups field. Replace padata_attr_type's default_attrs field
with default_groups and use the ATTRIBUTE_GROUPS macro to create
padata_default_groups.

This patch was tested by loading the pcrypt module and verifying that
the sysfs files for the attributes in the default groups were created.

Signed-off-by: Kimberly Brown <[email protected]>
---
kernel/padata.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/padata.c b/kernel/padata.c
index 3e2633ae3bca..2d2fddbb7a4c 100644
--- a/kernel/padata.c
+++ b/kernel/padata.c
@@ -957,6 +957,7 @@ static struct attribute *padata_default_attrs[] = {
&parallel_cpumask_attr.attr,
NULL,
};
+ATTRIBUTE_GROUPS(padata_default);

static ssize_t padata_sysfs_show(struct kobject *kobj,
struct attribute *attr, char *buf)
@@ -995,7 +996,7 @@ static const struct sysfs_ops padata_sysfs_ops = {

static struct kobj_type padata_attr_type = {
.sysfs_ops = &padata_sysfs_ops,
- .default_attrs = padata_default_attrs,
+ .default_groups = padata_default_groups,
.release = padata_sysfs_release,
};

--
2.17.1

2019-04-02 06:29:59

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH v2 0/8] kobject: Add default group support to kobj_type and replace subsystem uses

On Mon, Apr 01, 2019 at 10:51:10PM -0400, Kimberly Brown wrote:
> This patchset adds support for default attribute groups to kobj_type.
> Also, the uses of kobj_type's default_attrs field are replaced with
> default_groups in the following subsystems:
> - samples
> - block
> - net
> - irq
> - padata
> - cpufreq
> - livepatch
>
> The subsystem maintainers and lists will be copied on the subsystem
> patches.
>
> The uses of kobj_type's default_attrs field in the other subsystems will
> be replaced in future patchsets.
>
> Changes in v2:
> - Patch 1 is not changed.
> - Patches 2-8 are new.

Thanks so much for doing this.

As all of the different subsystems depend on the first patch, I'll be
glad to merge them all through my driver-core tree, or apply the first
one and wait a release cycle so that the others can go through the
individual subsystem's tree, depending on what the subsystem maintainer
is comfortable with.

thanks,

greg k-h

2019-04-25 20:13:24

by Greg Kroah-Hartman

[permalink] [raw]