2022-12-08 04:20:26

by Herbert Xu

Subject: Re: lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1120 bytes is larger than 1024 bytes

On Mon, Nov 07, 2022 at 09:18:05PM +0800, kernel test robot wrote:
> Hi Jason,
>
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: f0c4d9fc9cc9462659728d168387191387e903cc
> commit: 2d16803c562ecc644803d42ba98a8e0aef9c014e crypto: blake2s - remove shash module
> date: 5 months ago
> config: i386-buildonly-randconfig-r006-20221107
> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
> reproduce (this is a W=1 build):
> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d16803c562ecc644803d42ba98a8e0aef9c014e
> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> git fetch --no-tags linus master
> git checkout 2d16803c562ecc644803d42ba98a8e0aef9c014e

This was fixed months ago with

commit d6c14da474bf260d73953fbf7992c98d9112aec7
Author: Jason A. Donenfeld <[email protected]>
Date: Mon Jun 20 09:52:43 2022 +0200

crypto: lib/blake2s - reduce stack frame usage in self test

Why is LKP still testing the old commit?

Cheers,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-12-08 06:47:05

by Chen, Rong A

Subject: Re: lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1120 bytes is larger than 1024 bytes

On 12/8/2022 12:18 PM, Herbert Xu wrote:
> On Mon, Nov 07, 2022 at 09:18:05PM +0800, kernel test robot wrote:
>> Hi Jason,
>>
>> FYI, the error/warning still remains.
>>
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
>> head: f0c4d9fc9cc9462659728d168387191387e903cc
>> commit: 2d16803c562ecc644803d42ba98a8e0aef9c014e crypto: blake2s - remove shash module
>> date: 5 months ago
>> config: i386-buildonly-randconfig-r006-20221107
>> compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
>> reproduce (this is a W=1 build):
>> # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2d16803c562ecc644803d42ba98a8e0aef9c014e
>> git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
>> git fetch --no-tags linus master
>> git checkout 2d16803c562ecc644803d42ba98a8e0aef9c014e
>
> This was fixed months ago with
>
> commit d6c14da474bf260d73953fbf7992c98d9112aec7
> Author: Jason A. Donenfeld <[email protected]>
> Date: Mon Jun 20 09:52:43 2022 +0200
>
> crypto: lib/blake2s - reduce stack frame usage in self test
>
> Why is LKP still testing the old commit?

Hi Herbert,

Thanks for the information, I checked the result of the fix commit,
it reduced the stack frame but the warning still exists:

lib/crypto/blake2s-selftest.c:632:1: warning: the frame size of 1056
bytes is larger than 1024 bytes [-Wframe-larger-than=]

We'll ignore commit 2d16803c56 to avoid reporting it again.

Best Regards,
Rong Chen


>
> Cheers,
>