2019-11-29 18:17:16

by Eric Biggers

Subject: [PATCH] crypto: hisilicon - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

From: Eric Biggers <[email protected]>

Another instance of CRYPTO_BLKCIPHER made it in just after it was
renamed to CRYPTO_SKCIPHER. Fix it.

Fixes: 416d82204df4 ("crypto: hisilicon - add HiSilicon SEC V2 driver")
Signed-off-by: Eric Biggers <[email protected]>
---
drivers/crypto/hisilicon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index c0e7a85fe129..da749f6ecbea 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -16,7 +16,7 @@ config CRYPTO_DEV_HISI_SEC

config CRYPTO_DEV_HISI_SEC2
tristate "Support for HiSilicon SEC2 crypto block cipher accelerator"
- select CRYPTO_BLKCIPHER
+ select CRYPTO_SKCIPHER
select CRYPTO_ALGAPI
select CRYPTO_LIB_DES
select CRYPTO_DEV_HISI_QM
--
2.24.0

2019-11-30 02:45:54

by Xu Zaibo

Subject: Re: [PATCH] crypto: hisilicon - select CRYPTO_SKCIPHER, not CRYPTO_BLKCIPHER

On 2019/11/30 2:15, Eric Biggers wrote:
> From: Eric Biggers <[email protected]>
>
> Another instance of CRYPTO_BLKCIPHER made it in just after it was
> renamed to CRYPTO_SKCIPHER. Fix it.
Yes, thanks.

Cheers,
Zaibo
.
>
> Fixes: 416d82204df4 ("crypto: hisilicon - add HiSilicon SEC V2 driver")
> Signed-off-by: Eric Biggers <[email protected]>
> ---
> drivers/crypto/hisilicon/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index c0e7a85fe129..da749f6ecbea 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -16,7 +16,7 @@ config CRYPTO_DEV_HISI_SEC
>
> config CRYPTO_DEV_HISI_SEC2
> tristate "Support for HiSilicon SEC2 crypto block cipher accelerator"
> - select CRYPTO_BLKCIPHER
> + select CRYPTO_SKCIPHER
> select CRYPTO_ALGAPI
> select CRYPTO_LIB_DES
> select CRYPTO_DEV_HISI_QM