2023-01-11 12:14:26

by Lukas Bulwahn

Subject: [PATCH] crypto: hisilicon - remove redundant config PCI dependency for some CRYPTO_DEV_HISI configs

While reviewing dependencies in some Kconfig files, I noticed the redundant
dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always,
since its introduction, been dependent on the config PCI. So, it is
sufficient to just depend on PCI_MSI, and know that the dependency on PCI
is implicitly implied.

Reduce the dependencies of configs CRYPTO_DEV_HISI_SEC2,
CRYPTO_DEV_HISI_QM, CRYPTO_DEV_HISI_ZIP and CRYPTO_DEV_HISI_HPRE.

No functional change and effective change of Kconfig dependendencies.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
drivers/crypto/hisilicon/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
index 743ce4fc3158..4137a8bf131f 100644
--- a/drivers/crypto/hisilicon/Kconfig
+++ b/drivers/crypto/hisilicon/Kconfig
@@ -27,7 +27,7 @@ config CRYPTO_DEV_HISI_SEC2
select CRYPTO_SHA256
select CRYPTO_SHA512
select CRYPTO_SM4_GENERIC
- depends on PCI && PCI_MSI
+ depends on PCI_MSI
depends on UACCE || UACCE=n
depends on ARM64 || (COMPILE_TEST && 64BIT)
depends on ACPI
@@ -42,7 +42,7 @@ config CRYPTO_DEV_HISI_SEC2
config CRYPTO_DEV_HISI_QM
tristate
depends on ARM64 || COMPILE_TEST
- depends on PCI && PCI_MSI
+ depends on PCI_MSI
depends on UACCE || UACCE=n
depends on ACPI
help
@@ -51,7 +51,7 @@ config CRYPTO_DEV_HISI_QM

config CRYPTO_DEV_HISI_ZIP
tristate "Support for HiSilicon ZIP accelerator"
- depends on PCI && PCI_MSI
+ depends on PCI_MSI
depends on ARM64 || (COMPILE_TEST && 64BIT)
depends on !CPU_BIG_ENDIAN || COMPILE_TEST
depends on UACCE || UACCE=n
@@ -62,7 +62,7 @@ config CRYPTO_DEV_HISI_ZIP

config CRYPTO_DEV_HISI_HPRE
tristate "Support for HISI HPRE accelerator"
- depends on PCI && PCI_MSI
+ depends on PCI_MSI
depends on UACCE || UACCE=n
depends on ARM64 || (COMPILE_TEST && 64BIT)
depends on ACPI
--
2.17.1

2023-01-20 10:50:28

by Herbert Xu

Subject: Re: [PATCH] crypto: hisilicon - remove redundant config PCI dependency for some CRYPTO_DEV_HISI configs

On Wed, Jan 11, 2023 at 01:02:03PM +0100, Lukas Bulwahn wrote:
> While reviewing dependencies in some Kconfig files, I noticed the redundant
> dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always,
> since its introduction, been dependent on the config PCI. So, it is
> sufficient to just depend on PCI_MSI, and know that the dependency on PCI
> is implicitly implied.
>
> Reduce the dependencies of configs CRYPTO_DEV_HISI_SEC2,
> CRYPTO_DEV_HISI_QM, CRYPTO_DEV_HISI_ZIP and CRYPTO_DEV_HISI_HPRE.
>
> No functional change and effective change of Kconfig dependendencies.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/crypto/hisilicon/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2023-01-16 13:18:56

by Weili Qian

Subject: Re: [PATCH] crypto: hisilicon - remove redundant config PCI dependency for some CRYPTO_DEV_HISI configs

On 2023/1/11 20:02, Lukas Bulwahn wrote:
> While reviewing dependencies in some Kconfig files, I noticed the redundant
> dependency "depends on PCI && PCI_MSI". The config PCI_MSI has always,
> since its introduction, been dependent on the config PCI. So, it is
> sufficient to just depend on PCI_MSI, and know that the dependency on PCI
> is implicitly implied.
>
> Reduce the dependencies of configs CRYPTO_DEV_HISI_SEC2,
> CRYPTO_DEV_HISI_QM, CRYPTO_DEV_HISI_ZIP and CRYPTO_DEV_HISI_HPRE.
>
> No functional change and effective change of Kconfig dependendencies.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> drivers/crypto/hisilicon/Kconfig | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
Acked-by: Weili Qian <[email protected]>

> diff --git a/drivers/crypto/hisilicon/Kconfig b/drivers/crypto/hisilicon/Kconfig
> index 743ce4fc3158..4137a8bf131f 100644
> --- a/drivers/crypto/hisilicon/Kconfig
> +++ b/drivers/crypto/hisilicon/Kconfig
> @@ -27,7 +27,7 @@ config CRYPTO_DEV_HISI_SEC2
> select CRYPTO_SHA256
> select CRYPTO_SHA512
> select CRYPTO_SM4_GENERIC
> - depends on PCI && PCI_MSI
> + depends on PCI_MSI
> depends on UACCE || UACCE=n
> depends on ARM64 || (COMPILE_TEST && 64BIT)
> depends on ACPI
> @@ -42,7 +42,7 @@ config CRYPTO_DEV_HISI_SEC2
> config CRYPTO_DEV_HISI_QM
> tristate
> depends on ARM64 || COMPILE_TEST
> - depends on PCI && PCI_MSI
> + depends on PCI_MSI
> depends on UACCE || UACCE=n
> depends on ACPI
> help
> @@ -51,7 +51,7 @@ config CRYPTO_DEV_HISI_QM
>
> config CRYPTO_DEV_HISI_ZIP
> tristate "Support for HiSilicon ZIP accelerator"
> - depends on PCI && PCI_MSI
> + depends on PCI_MSI
> depends on ARM64 || (COMPILE_TEST && 64BIT)
> depends on !CPU_BIG_ENDIAN || COMPILE_TEST
> depends on UACCE || UACCE=n
> @@ -62,7 +62,7 @@ config CRYPTO_DEV_HISI_ZIP
>
> config CRYPTO_DEV_HISI_HPRE
> tristate "Support for HISI HPRE accelerator"
> - depends on PCI && PCI_MSI
> + depends on PCI_MSI
> depends on UACCE || UACCE=n
> depends on ARM64 || (COMPILE_TEST && 64BIT)
> depends on ACPI
>