2023-11-05 13:03:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RESEND PATCH] dt-bindings: crypto: qcom,prng: Add SM8450

On 03/11/2023 23:52, Elliot Berman wrote:
> From: Konrad Dybcio <[email protected]>
>
> SM8450's PRNG does not require a core clock reference. Add a new
> compatible with a qcom,prng-ee fallback and handle that.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> Acked-by: Conor Dooley <[email protected]>
> Signed-off-by: Elliot Berman <[email protected]>
> ---
> I noticed this patch got missed while running make dtbs_check. No
> changes to this patch from the original version:
>
> https://lore.kernel.org/all/[email protected]/
>

I don't understand why do you send this. This is not a correct patch,
was rejected. Different patch was already merged.

Best regards,
Krzysztof


2023-11-06 17:06:18

by Elliot Berman

[permalink] [raw]
Subject: Re: [RESEND PATCH] dt-bindings: crypto: qcom,prng: Add SM8450



On 11/5/2023 5:03 AM, Krzysztof Kozlowski wrote:
> On 03/11/2023 23:52, Elliot Berman wrote:
>> From: Konrad Dybcio <[email protected]>
>>
>> SM8450's PRNG does not require a core clock reference. Add a new
>> compatible with a qcom,prng-ee fallback and handle that.
>>
>> Signed-off-by: Konrad Dybcio <[email protected]>
>> Acked-by: Conor Dooley <[email protected]>
>> Signed-off-by: Elliot Berman <[email protected]>
>> ---
>> I noticed this patch got missed while running make dtbs_check. No
>> changes to this patch from the original version:
>>
>> https://lore.kernel.org/all/[email protected]/
>>
>
> I don't understand why do you send this. This is not a correct patch,
> was rejected. Different patch was already merged.

I see that 6.6 has

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sm8450.dtsi?h=v6.6#n1741

but bindings not updated:

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/crypto/qcom,prng.yaml?h=v6.6

I came up with similar-ish fix offline, then found Konrad had posted the patch when searching lore.
I didn't find any other patch on lore.

I think you rejected a proposal to drop "p" from "prng", but this patch
doesn't do that and we stayed course with naming scheme.

Thanks,

Elliot