2022-04-24 00:00:52

by Jason A. Donenfeld

Subject: [PATCH v6 03/17] parisc: define get_cycles macro for arch-override

PA-RISC defines a get_cycles() function, but it forgot to do the usual
`#define get_cycles get_cycles` dance, making it impossible for generic
code to see if an arch-specific function was defined.

Cc: Thomas Gleixner <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Helge Deller <[email protected]>
Signed-off-by: Jason A. Donenfeld <[email protected]>
---
arch/parisc/include/asm/timex.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/parisc/include/asm/timex.h b/arch/parisc/include/asm/timex.h
index 06b510f8172e..b4622cb06a75 100644
--- a/arch/parisc/include/asm/timex.h
+++ b/arch/parisc/include/asm/timex.h
@@ -13,9 +13,10 @@

typedef unsigned long cycles_t;

-static inline cycles_t get_cycles (void)
+static inline cycles_t get_cycles(void)
{
return mfctl(16);
}
+#define get_cycles get_cycles

#endif
--
2.35.1

2022-04-24 22:01:49

by Helge Deller

Subject: Re: [PATCH v6 03/17] parisc: define get_cycles macro for arch-override

On 4/23/22 23:26, Jason A. Donenfeld wrote:
> PA-RISC defines a get_cycles() function, but it forgot to do the usual
> `#define get_cycles get_cycles` dance, making it impossible for generic
> code to see if an arch-specific function was defined.
>
> Cc: Thomas Gleixner <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Helge Deller <[email protected]>
> Signed-off-by: Jason A. Donenfeld <[email protected]>

Acked-by: Helge Deller <[email protected]> # parisc

Thank you!
Helge

> ---
> arch/parisc/include/asm/timex.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/parisc/include/asm/timex.h b/arch/parisc/include/asm/timex.h
> index 06b510f8172e..b4622cb06a75 100644
> --- a/arch/parisc/include/asm/timex.h
> +++ b/arch/parisc/include/asm/timex.h
> @@ -13,9 +13,10 @@
>
> typedef unsigned long cycles_t;
>
> -static inline cycles_t get_cycles (void)
> +static inline cycles_t get_cycles(void)
> {
> return mfctl(16);
> }
> +#define get_cycles get_cycles
>
> #endif