2023-04-26 18:46:00

by Palmer Dabbelt

[permalink] [raw]
Subject: Re: [PATCH V4 10/23] RISC-V: smpboot: Create wrapper smp_setup()

On Tue, 04 Apr 2023 11:20:24 PDT (-0700), [email protected] wrote:
> smp_setup() currently assumes DT-based platforms. To enable ACPI,
> first make this a wrapper function and move existing code to
> a separate DT-specific function.
>
> Signed-off-by: Sunil V L <[email protected]>
> Acked-by: Rafael J. Wysocki <[email protected]>
> Reviewed-by: Conor Dooley <[email protected]>
> Reviewed-by: Andrew Jones <[email protected]>
> ---
> arch/riscv/kernel/smpboot.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/smpboot.c b/arch/riscv/kernel/smpboot.c
> index 00b53913d4c6..26214ddefaa4 100644
> --- a/arch/riscv/kernel/smpboot.c
> +++ b/arch/riscv/kernel/smpboot.c
> @@ -70,7 +70,7 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
> }
> }
>
> -void __init setup_smp(void)
> +static void __init of_parse_and_init_cpus(void)
> {
> struct device_node *dn;
> unsigned long hart;
> @@ -116,6 +116,11 @@ void __init setup_smp(void)
> }
> }
>
> +void __init setup_smp(void)
> +{
> + of_parse_and_init_cpus();
> +}
> +
> static int start_secondary_cpu(int cpu, struct task_struct *tidle)
> {
> if (cpu_ops[cpu]->cpu_start)

Reviewed-by: Palmer Dabbelt <[email protected]>