2024-03-29 11:46:21

by Stefano Garzarella

[permalink] [raw]
Subject: Re: [PATCH 16/22] net: vmw_vsock: virtio: drop owner assignment

On Wed, Mar 27, 2024 at 01:41:09PM +0100, Krzysztof Kozlowski wrote:
>virtio core already sets the .owner, so driver does not need to.
>
>Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
>---
>
>Depends on the first patch.
>---
> net/vmw_vsock/virtio_transport.c | 1 -
> 1 file changed, 1 deletion(-)

Acked-by: Stefano Garzarella <[email protected]>

Nit: you can use "vsock/virtio: " as prefix for the commit title.

>
>diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
>index 1748268e0694..13f42a62b034 100644
>--- a/net/vmw_vsock/virtio_transport.c
>+++ b/net/vmw_vsock/virtio_transport.c
>@@ -858,7 +858,6 @@ static struct virtio_driver virtio_vsock_driver = {
> .feature_table = features,
> .feature_table_size = ARRAY_SIZE(features),
> .driver.name = KBUILD_MODNAME,
>- .driver.owner = THIS_MODULE,
> .id_table = id_table,
> .probe = virtio_vsock_probe,
> .remove = virtio_vsock_remove,
>
>--
>2.34.1
>