2008-11-12 21:01:05

by Randy Dunlap

[permalink] [raw]

Subject: [PATCH linux-next] : Tree for November 12 (libcrc32c)

---

From: Randy Dunlap <[email protected]>

libcrc32c uses CRYPTO interfaces so it should depend on CRYPTO.

crypto/built-in.o: In function `crc32c_mod_init':
crc32c.c:(.init.text+0xc): undefined reference to `crypto_register_shash'
crypto/built-in.o: In function `crc32c_mod_fini':
crc32c.c:(.exit.text+0xc): undefined reference to `crypto_unregister_shash'
lib/built-in.o: In function `crc32c':
(.text+0xfcf9): undefined reference to `crypto_shash_update'
lib/built-in.o: In function `libcrc32c_mod_init':
libcrc32c.c:(.init.text+0x666): undefined reference to `crypto_alloc_shash'
lib/built-in.o: In function `libcrc32c_mod_fini':
libcrc32c.c:(.exit.text+0xc): undefined reference to `crypto_free_tfm'

Signed-off-by: Randy Dunlap <[email protected]>
---
lib/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20081112.orig/lib/Kconfig
+++ linux-next-20081112/lib/Kconfig
@@ -64,6 +64,7 @@ config CRC7

config LIBCRC32C
tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check"
+ depends on CRYPTO
select CRYPTO_CRC32C
help
This option is provided for the case where no in-kernel-tree

---

Attachments:

config-old (30.68 kB)

2008-11-13 14:09:28

by Herbert Xu

[permalink] [raw]

Subject: Re: [PATCH linux-next] : Tree for November 12 (libcrc32c)

---

On Wed, Nov 12, 2008 at 01:01:05PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> libcrc32c uses CRYPTO interfaces so it should depend on CRYPTO.
>
> crypto/built-in.o: In function `crc32c_mod_init':
> crc32c.c:(.init.text+0xc): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `crc32c_mod_fini':
> crc32c.c:(.exit.text+0xc): undefined reference to `crypto_unregister_shash'
> lib/built-in.o: In function `crc32c':
> (.text+0xfcf9): undefined reference to `crypto_shash_update'
> lib/built-in.o: In function `libcrc32c_mod_init':
> libcrc32c.c:(.init.text+0x666): undefined reference to `crypto_alloc_shash'
> lib/built-in.o: In function `libcrc32c_mod_fini':
> libcrc32c.c:(.exit.text+0xc): undefined reference to `crypto_free_tfm'
>
> Signed-off-by: Randy Dunlap <[email protected]>

Thanks, I've fixed it as follows:

commit d9cc217c79df50f9a9f7937aeaa54d89ae198686
Author: Herbert Xu <[email protected]>
Date: Thu Nov 13 22:05:13 2008 +0800

libcrc32c: Select CRYPTO in Kconfig

Selecting CRYPTO_CRC32C is not enough as CRYPTO which CRYPTO_CRC32C
depends on may be disabled. This patch adds the select on CRYPTO.

Signed-off-by: Herbert Xu <[email protected]>

diff --git a/lib/Kconfig b/lib/Kconfig
index d09edb7..963009a 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -64,6 +64,7 @@ config CRC7

config LIBCRC32C
tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check"
+ select CRYPTO
select CRYPTO_CRC32C
help
This option is provided for the case where no in-kernel-tree

--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt