2022-09-17 09:55:53

by williamsukatube

Subject: [PATCH -next] hwrng: Remove duplicate include

From: William Dean <[email protected]>

In file: drivers/char/hw_random/core.c,
'#include <linux/random.h>' has included at line: 18,
now it is duplicated include at line: 24, so delete duplicated include.

Signed-off-by: William Dean <[email protected]>
---
drivers/char/hw_random/core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index 16f227b995e8..56d171cd2fc6 100644
--- a/drivers/char/hw_random/core.c
+++ b/drivers/char/hw_random/core.c
@@ -21,7 +21,6 @@
#include <linux/sched/signal.h>
#include <linux/miscdevice.h>
#include <linux/module.h>
-#include <linux/random.h>
#include <linux/sched.h>
#include <linux/slab.h>
#include <linux/uaccess.h>
--
2.25.1

2022-09-24 07:33:14

by Herbert Xu

Subject: Re: [PATCH -next] hwrng: Remove duplicate include

[email protected] wrote:
> From: William Dean <[email protected]>
>
> In file: drivers/char/hw_random/core.c,
> '#include <linux/random.h>' has included at line: 18,
> now it is duplicated include at line: 24, so delete duplicated include.
>
> Signed-off-by: William Dean <[email protected]>
> ---
> drivers/char/hw_random/core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
> index 16f227b995e8..56d171cd2fc6 100644
> --- a/drivers/char/hw_random/core.c
> +++ b/drivers/char/hw_random/core.c
> @@ -21,7 +21,6 @@
> #include <linux/sched/signal.h>
> #include <linux/miscdevice.h>
> #include <linux/module.h>
> -#include <linux/random.h>
> #include <linux/sched.h>
> #include <linux/slab.h>
> #include <linux/uaccess.h>

This is supposed to be sorted so please remove the other inclusion
instead.

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt