2013-11-29 06:50:40

by Kazuya Mio

Subject: [PATCH v2] mke2fs: fix force option to create filesystem on mounted device

This is v2 patch added reviewed-by.
Could you check and merge this patch if possible?


According to mke2fs man, we can create a filesystem on the mounted device
when -FF option is specified.
However, currently we have to specify -F option third to force mke2fs.
This patch fixes the problem.

Signed-off-by: Kazuya Mio <[email protected]>
Reviewed-by: Zheng Liu <[email protected]>
Reviewed-by: Carlos Maiolino <[email protected]>
---
misc/util.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/misc/util.c b/misc/util.c
index 6c93e1c..40c8858 100644
--- a/misc/util.c
+++ b/misc/util.c
@@ -150,7 +150,7 @@ void check_mount(const char *device, int force, const char *type)
}
if (mount_flags & EXT2_MF_MOUNTED) {
fprintf(stderr, _("%s is mounted; "), device);
- if (force > 2) {
+ if (force >= 2) {
fputs(_("mke2fs forced anyway. Hope /etc/mtab is "
"incorrect.\n"), stderr);
return;
@@ -162,7 +162,7 @@ void check_mount(const char *device, int force, const char *type)
if (mount_flags & EXT2_MF_BUSY) {
fprintf(stderr, _("%s is apparently in use by the system; "),
device);
- if (force > 2) {
+ if (force >= 2) {
fputs(_("mke2fs forced anyway.\n"), stderr);
return;
}

2013-12-16 05:43:15

by Theodore Ts'o

Subject: Re: [PATCH v2] mke2fs: fix force option to create filesystem on mounted device

On Fri, Nov 29, 2013 at 03:30:41PM +0900, Kazuya Mio wrote:
>
> According to mke2fs man, we can create a filesystem on the mounted device
> when -FF option is specified.
> However, currently we have to specify -F option third to force mke2fs.
> This patch fixes the problem.
>
> Signed-off-by: Kazuya Mio <[email protected]>
> Reviewed-by: Zheng Liu <[email protected]>
> Reviewed-by: Carlos Maiolino <[email protected]>

Applied, thanks.

- Ted