LinuxLists.cc - [tytso-ext4:dev 16/43] fs/ext4/balloc.c:153 ext4_num_overhead_clusters() error: uninitialized symbol 'block

2023-03-18 07:43:49

Subject: [tytso-ext4:dev 16/43] fs/ext4/balloc.c:153 ext4_num_overhead_clusters() error: uninitialized symbol 'block_cluster'.

tree: smatch warnings:
fs/ext4/balloc.c:153
vim +/block_cluster
c197855ea14175a Stephen e187c6588d6ef31 Theodore Ts'o e187c6588d6ef31 Theodore Ts'o 0bf7e8379ce7e01 Jose R. Santos e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi d5b8f31007a9377 Theodore Ts'o e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi 0bf7e8379ce7e01 Jose R. Santos 0bf7e8379ce7e01 Jose R. Santos d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi 0bf7e8379ce7e01 Jose R. Santos d5b8f31007a9377 Theodore Ts'o e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o b0dd6b70f0fda17 Theodore Ts'o b0dd6b70f0fda17 Theodore Ts'o e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o
block_cluster not past but I don't
d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o b0dd6b70f0fda17 Theodore Ts'o e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi e3c70113e2cbeb3 Kemeng Shi d5b8f31007a9377 Theodore Ts'o 0bf7e8379ce7e01 Jose R. Santos d5b8f31007a9377 Theodore Ts'o d5b8f31007a9377 Theodore Ts'o 0bf7e8379ce7e01 Jose R. Santos
--
0-DAY CI Kernel Test Service
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git dev
cfad712da9e17adf9a26eb
b3768964920337eff290f6 [16/43] ext4: improve inode table blocks counting in ext4_num_overhead_clusters
(https://download.01.org/0day-ci/archive/20230317/[email protected]/config)
(GCC) 12.1.0
kindly add following tag where applicable
test robot <[email protected]>
Carpenter <[email protected]>
lore.kernel.org/r/202303171446.eLEhZzAu-lkp@intel.com/">https://lore.kernel.org/r/[email protected]/
ext4_num_overhead_clusters() error: uninitialized symbol 'block_cluster'.
+153 fs/ext4/balloc.c
Hemminger 2014-05-12 87 static unsigned ext4_num_overhead_clusters(struct super_block *sb,
2009-02-06 88 ext4_group_t block_group,
2009-02-06 89 struct ext4_group_desc *gdp)
2008-06-03 90 {
2023-02-21 91 unsigned base_clusters, num_clusters;
2023-02-21 92 int block_cluster, inode_cluster;
2023-02-21 93 int itbl_cluster_start = -1, itbl_cluster_end = -1;
2011-09-09 94 ext4_fsblk_t start = ext4_group_first_block_no(sb, block_group);
2023-02-21 95 ext4_fsblk_t end = start + EXT4_BLOCKS_PER_GROUP(sb) - 1;
2023-02-21 96 ext4_fsblk_t itbl_blk_start, itbl_blk_end;
2008-06-03 97 struct ext4_sb_info *sbi = EXT4_SB(sb);
2008-06-03 98
2011-09-09 99 /* This is the number of clusters used by the superblock,
2011-09-09 100 * block group descriptors, and reserved block group
2011-09-09 101 * descriptor blocks */
2023-02-21 102 base_clusters = ext4_num_base_meta_clusters(sb, block_group);
2023-02-21 103 num_clusters = base_clusters;
2023-02-21 104
2023-02-21 105 /*
2023-02-21 106 * Account and record inode table clusters if any cluster
2023-02-21 107 * is in the block group, or inode table cluster range is
2023-02-21 108 * [-1, -1] and won't overlap with block/inode bitmap cluster
2023-02-21 109 * accounted below.
2023-02-21 110 */
2023-02-21 111 itbl_blk_start = ext4_inode_table(sb, gdp);
2023-02-21 112 itbl_blk_end = itbl_blk_start + sbi->s_itb_per_group - 1;
2023-02-21 113 if (itbl_blk_start <= end && itbl_blk_end >= start) {
2023-02-21 114 itbl_blk_start = itbl_blk_start >= start ?
2023-02-21 115 itbl_blk_start : start;
2023-02-21 116 itbl_blk_end = itbl_blk_end <= end ?
2023-02-21 117 itbl_blk_end : end;
2023-02-21 118
2023-02-21 119 itbl_cluster_start = EXT4_B2C(sbi, itbl_blk_start - start);
2023-02-21 120 itbl_cluster_end = EXT4_B2C(sbi, itbl_blk_end - start);
2023-02-21 121
2023-02-21 122 num_clusters += itbl_cluster_end - itbl_cluster_start + 1;
2023-02-21 123 /* check if border cluster is overlapped */
2023-02-21 124 if (itbl_cluster_start == base_clusters - 1)
2023-02-21 125 num_clusters--;
2023-02-21 126 }
2008-06-03 127
2011-09-09 128 /*
2023-02-21 129 * For the allocation bitmaps, we first need to check to see
2023-02-21 130 * if the block is in the block group. If it is, then check
2023-02-21 131 * to see if the cluster is already accounted for in the clusters
2023-02-21 132 * used for the base metadata cluster and inode tables cluster.
2011-09-09 133 * Normally all of these blocks are contiguous, so the special
2011-09-09 134 * case handling shouldn't be necessary except for *very*
2011-09-09 135 * unusual file system layouts.
2011-09-09 136 */
2011-09-09 137 if (ext4_block_in_group(sb, ext4_block_bitmap(sb, gdp), block_group)) {
2012-06-07 138 block_cluster = EXT4_B2C(sbi,
2012-06-07 139 ext4_block_bitmap(sb, gdp) - start);
2023-02-21 140 if (block_cluster >= base_clusters &&
2023-02-21 141 (block_cluster < itbl_cluster_start ||
2023-02-21 142 block_cluster > itbl_cluster_end))
2011-09-09 143 num_clusters++;
2011-09-09 144 }
initialized on else path. We discussed this in the
see on lore if it was actually fixed.
2011-09-09 145
2011-09-09 146 if (ext4_block_in_group(sb, ext4_inode_bitmap(sb, gdp), block_group)) {
2011-09-09 147 inode_cluster = EXT4_B2C(sbi,
2012-06-07 148 ext4_inode_bitmap(sb, gdp) - start);
2023-02-21 149 /*
2023-02-21 150 * Additional check if inode bitmap is in just accounted
2023-02-21 151 * block_cluster
2023-02-21 152 */
2023-02-21 @153 if (inode_cluster != block_cluster &&
2023-02-21 154 inode_cluster >= base_clusters &&
2023-02-21 155 (inode_cluster < itbl_cluster_start ||
2023-02-21 156 inode_cluster > itbl_cluster_end))
2011-09-09 157 num_clusters++;
2008-06-03 158 }
2011-09-09 159
2011-09-09 160 return num_clusters;
2008-06-03 161 }
om/intel/lkp-tests">https://github.com/intel/lkp-tests