2008-02-17 06:17:55

by Akinobu Mita

[permalink] [raw]
Subject: [PATCH 2/4] ext4: add missing ext4_journal_stop()

Add missing ext4_journal_stop() in error handling.

Signed-off-by: Akinobu Mita <[email protected]>
Cc: Stephen Tweedie <[email protected]>
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
Cc: Mingming Cao <[email protected]>
Cc: Theodore Tso <[email protected]>
---
fs/ext4/resize.c | 1 +
1 file changed, 1 insertion(+)

Index: 2.6-rc/fs/ext4/resize.c
===================================================================
--- 2.6-rc.orig/fs/ext4/resize.c
+++ 2.6-rc/fs/ext4/resize.c
@@ -1037,6 +1037,7 @@ int ext4_group_extend(struct super_block
ext4_warning(sb, __FUNCTION__,
"multiple resizers run on filesystem!");
unlock_super(sb);
+ ext4_journal_stop(handle);
err = -EBUSY;
goto exit_put;
}


2008-02-19 07:45:49

by Mingming Cao

[permalink] [raw]
Subject: Re: [PATCH 2/4] ext4: add missing ext4_journal_stop()

On Sun, 2008-02-17 at 15:11 +0900, Akinobu Mita wrote:
> Add missing ext4_journal_stop() in error handling.
>
Reviewed and Acked ext2/3/4 changes.

ext4 patch is also queued in ext4 patch queue
http://repo.or.cz/w/ext4-patch-queue.git

Mingming
> Signed-off-by: Akinobu Mita <[email protected]>
> Cc: Stephen Tweedie <[email protected]>
> Cc: [email protected]
> Cc: Andrew Morton <[email protected]>
> Cc: Mingming Cao <[email protected]>
> Cc: Theodore Tso <[email protected]>
> ---
> fs/ext4/resize.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: 2.6-rc/fs/ext4/resize.c
> ===================================================================
> --- 2.6-rc.orig/fs/ext4/resize.c
> +++ 2.6-rc/fs/ext4/resize.c
> @@ -1037,6 +1037,7 @@ int ext4_group_extend(struct super_block
> ext4_warning(sb, __FUNCTION__,
> "multiple resizers run on filesystem!");
> unlock_super(sb);
> + ext4_journal_stop(handle);
> err = -EBUSY;
> goto exit_put;
> }
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html