LinuxLists.cc - [RFC] EXT_MAX_BLOCK for >= 16TB fs

2008-07-07 17:30:12

Subject: [RFC] EXT_MAX_BLOCK for >= 16TB fs

Hi,
The magic constant EXT_MAX_BLOCK = 0xffffffff in extents code is used
in some places to return "invalid block number", and to set the extent
length = "whole file" in other places.
So with >= 16 TB fs we would prefer to use it differently. We can have
EXT_UNSET_BLOCK = 1 to indicate "invalid block number" as it will never
be valid block for allocation. And for "whole file" usecase we can
continue using current EXT_MAX_BLOCK

Regards,
Girish

2008-07-08 12:51:25

by Girish Shilamkar

[permalink] [raw]

Subject: [PATCH] EXT_MAX_BLOCK for >= 16TB fs

Hi,
Here is the patch for same.

Thanks,
Girish

On Mon, 2008-07-07 at 22:25 +0530, Girish Shilamkar wrote:
> Hi,
> The magic constant EXT_MAX_BLOCK = 0xffffffff in extents code is used
> in some places to return "invalid block number", and to set the extent
> length = "whole file" in other places.
> So with >= 16 TB fs we would prefer to use it differently. We can have
> EXT_UNSET_BLOCK = 1 to indicate "invalid block number" as it will never
> be valid block for allocation. And for "whole file" usecase we can
> continue using current EXT_MAX_BLOCK
>
> Regards,
> Girish
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2008-07-08 14:59:18

by Girish Shilamkar

[permalink] [raw]

Subject: Re: [PATCH] EXT_MAX_BLOCK for >= 16TB fs

Oops ...

On Tue, 2008-07-08 at 18:21 +0530, Girish Shilamkar wrote:
> Hi,
> Here is the patch for same.
>
> Thanks,
> Girish
>
> On Mon, 2008-07-07 at 22:25 +0530, Girish Shilamkar wrote:
> > Hi,
> > The magic constant EXT_MAX_BLOCK = 0xffffffff in extents code is used
> > in some places to return "invalid block number", and to set the extent
> > length = "whole file" in other places.
> > So with >= 16 TB fs we would prefer to use it differently. We can have
> > EXT_UNSET_BLOCK = 1 to indicate "invalid block number" as it will never
> > be valid block for allocation. And for "whole file" usecase we can
> > continue using current EXT_MAX_BLOCK
> >
> > Regards,
> > Girish
> >
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Attachments:

Fix-EXT_MAX_BLOCK.patch (82.64 kB)

2008-07-08 18:12:47

by Girish Shilamkar

[permalink] [raw]

Subject: Re: [PATCH] EXT_MAX_BLOCK for >= 16TB fs

Hi,
Please disregard the last mail as it had incorrect patch, sorry for
that.
The correct patch is attached here.

Thanks,
Girish

On Tue, 2008-07-08 at 18:52 +0530, Girish Shilamkar wrote:
> Oops ...
>
> On Tue, 2008-07-08 at 18:21 +0530, Girish Shilamkar wrote:
> > Hi,
> > Here is the patch for same.
> >
> > Thanks,
> > Girish
> >
> > On Mon, 2008-07-07 at 22:25 +0530, Girish Shilamkar wrote:
> > > Hi,
> > > The magic constant EXT_MAX_BLOCK = 0xffffffff in extents code is used
> > > in some places to return "invalid block number", and to set the extent
> > > length = "whole file" in other places.
> > > So with >= 16 TB fs we would prefer to use it differently. We can have
> > > EXT_UNSET_BLOCK = 1 to indicate "invalid block number" as it will never
> > > be valid block for allocation. And for "whole file" usecase we can
> > > continue using current EXT_MAX_BLOCK
> > >
> > > Regards,
> > > Girish
> > >
> > >
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > > the body of a message to [email protected]
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html

Attachments:

change-EXT_MAX_BLOCK.patch (3.54 kB)

2008-07-08 23:56:41

by Mingming Cao

[permalink] [raw]

Subject: Re: [PATCH] EXT_MAX_BLOCK for >= 16TB fs

Girish, thanks for sending out the patch. Looks like it's agains ext3,
could you please port it to ext4?

Thanks,
Mingming
在 2008-07-08二的 18:52 +0530，Girish Shilamkar写道：
> Oops ...
>
> On Tue, 2008-07-08 at 18:21 +0530, Girish Shilamkar wrote:
> > Hi,
> > Here is the patch for same.
> >
> > Thanks,
> > Girish
> >
> > On Mon, 2008-07-07 at 22:25 +0530, Girish Shilamkar wrote:
> > > Hi,
> > > The magic constant EXT_MAX_BLOCK = 0xffffffff in extents code is used
> > > in some places to return "invalid block number", and to set the extent
> > > length = "whole file" in other places.
> > > So with >= 16 TB fs we would prefer to use it differently. We can have
> > > EXT_UNSET_BLOCK = 1 to indicate "invalid block number" as it will never
> > > be valid block for allocation. And for "whole file" usecase we can
> > > continue using current EXT_MAX_BLOCK
> > >
> > > Regards,
> > > Girish
> > >
> > >
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > > the body of a message to [email protected]
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html

2008-07-08 23:58:13

by Mingming Cao

[permalink] [raw]

Subject: Re: [PATCH] EXT_MAX_BLOCK for >= 16TB fs

oops, I saw your updated patch, thanks
在 2008-07-08二的 16:56 -0700，Mingming Cao写道：
> Girish, thanks for sending out the patch. Looks like it's agains ext3,
> could you please port it to ext4?
>
> Thanks,
> Mingming
> 在 2008-07-08二的 18:52 +0530，Girish Shilamkar写道：
> > Oops ...
> >
> > On Tue, 2008-07-08 at 18:21 +0530, Girish Shilamkar wrote:
> > > Hi,
> > > Here is the patch for same.
> > >
> > > Thanks,
> > > Girish
> > >
> > > On Mon, 2008-07-07 at 22:25 +0530, Girish Shilamkar wrote:
> > > > Hi,
> > > > The magic constant EXT_MAX_BLOCK = 0xffffffff in extents code is used
> > > > in some places to return "invalid block number", and to set the extent
> > > > length = "whole file" in other places.
> > > > So with >= 16 TB fs we would prefer to use it differently. We can have
> > > > EXT_UNSET_BLOCK = 1 to indicate "invalid block number" as it will never
> > > > be valid block for allocation. And for "whole file" usecase we can
> > > > continue using current EXT_MAX_BLOCK
> > > >
> > > > Regards,
> > > > Girish
> > > >
> > > >
> > > >
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > > > the body of a message to [email protected]
> > > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > > the body of a message to [email protected]
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html