2008-07-31 17:58:25

by Eric Sandeen

Subject: [PATCH] remove write-only variables from ext4_ordered_write_end

from & to are unused.

Signed-off-by: Eric Sandeen <[email protected]>
---

Index: linux-2.6/fs/ext4/inode.c
===================================================================
--- linux-2.6.orig/fs/ext4/inode.c 2008-07-31 12:38:45.000000000 -0500
+++ linux-2.6/fs/ext4/inode.c 2008-07-31 12:55:59.181165399 -0500
@@ -1336,12 +1336,8 @@ static int ext4_ordered_write_end(struct
{
handle_t *handle = ext4_journal_current_handle();
struct inode *inode = mapping->host;
- unsigned from, to;
int ret = 0, ret2;

- from = pos & (PAGE_CACHE_SIZE - 1);
- to = from + len;

2008-07-31 18:09:18

by Mingming Cao

Subject: Re: [PATCH] remove write-only variables from ext4_ordered_write_end

在 2008-07-31四的 12:57 -0500，Eric Sandeen写道：
> from & to are unused.
>
> Signed-off-by: Eric Sandeen <[email protected]>
> ---

Acked-by: Mingming Cao <[email protected]>
>
> Index: linux-2.6/fs/ext4/inode.c
> ===================================================================
> --- linux-2.6.orig/fs/ext4/inode.c 2008-07-31 12:38:45.000000000 -0500
> +++ linux-2.6/fs/ext4/inode.c 2008-07-31 12:55:59.181165399 -0500
> @@ -1336,12 +1336,8 @@ static int ext4_ordered_write_end(struct
> {
> handle_t *handle = ext4_journal_current_handle();
> struct inode *inode = mapping->host;
> - unsigned from, to;
> int ret = 0, ret2;
>
> - from = pos & (PAGE_CACHE_SIZE - 1);
> - to = from + len;
> -
> ret = ext4_jbd2_file_inode(handle, inode);
>
> if (ret == 0) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html