The patch changes the order that the config file and command line are
parsed so that command line has precedence. It also adds a check to
make sure only one -E option is passed on the command line as -E option
parsing is not cumulative.
Signed-off-by: Jim Garlick <[email protected]>
Signed-off-by: Andreas Dilger <[email protected]>
On Mon, Oct 06, 2008 at 04:01:08PM +0530, Kalpak Shah wrote:
> The patch changes the order that the config file and command line are
> parsed so that command line has precedence. It also adds a check to
> make sure only one -E option is passed on the command line as -E option
> parsing is not cumulative.
Hmm. I wonder if we would be better off making -E option parsing
cumulative, especially if we are going to add a way of specifying some
extended options via the config file. Comments?
- Ted
On Oct 06, 2008 16:49 -0400, Theodore Ts'o wrote:
> On Mon, Oct 06, 2008 at 04:01:08PM +0530, Kalpak Shah wrote:
> > The patch changes the order that the config file and command line are
> > parsed so that command line has precedence. It also adds a check to
> > make sure only one -E option is passed on the command line as -E option
> > parsing is not cumulative.
>
> Hmm. I wonder if we would be better off making -E option parsing
> cumulative, especially if we are going to add a way of specifying some
> extended options via the config file. Comments?
I've always thought that both -E and -O should be cumulative.
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.