2009-09-04 13:49:32

by Tobias Klauser

Subject: [PATCH] ext4: Make seq_operations and file_operations const

Signed-off-by: Tobias Klauser <[email protected]>
---
fs/ext4/mballoc.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index cd25846..a10b1c5 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2205,7 +2205,7 @@ static void ext4_mb_seq_history_stop(struct seq_file *seq, void *v)
{
}

-static struct seq_operations ext4_mb_seq_history_ops = {
+static const struct seq_operations ext4_mb_seq_history_ops = {
.start = ext4_mb_seq_history_start,
.next = ext4_mb_seq_history_next,
.stop = ext4_mb_seq_history_stop,
@@ -2287,7 +2287,7 @@ static ssize_t ext4_mb_seq_history_write(struct file *file,
return count;
}

-static struct file_operations ext4_mb_seq_history_fops = {
+static const struct file_operations ext4_mb_seq_history_fops = {
.owner = THIS_MODULE,
.open = ext4_mb_seq_history_open,
.read = seq_read,
@@ -2366,7 +2366,7 @@ static void ext4_mb_seq_groups_stop(struct seq_file *seq, void *v)
{
}

-static struct seq_operations ext4_mb_seq_groups_ops = {
+static const struct seq_operations ext4_mb_seq_groups_ops = {
.start = ext4_mb_seq_groups_start,
.next = ext4_mb_seq_groups_next,
.stop = ext4_mb_seq_groups_stop,
@@ -2387,7 +2387,7 @@ static int ext4_mb_seq_groups_open(struct inode *inode, struct file *file)

}

-static struct file_operations ext4_mb_seq_groups_fops = {
+static const struct file_operations ext4_mb_seq_groups_fops = {
.owner = THIS_MODULE,
.open = ext4_mb_seq_groups_open,
.read = seq_read,
--
1.6.0.4

2009-09-05 13:29:54

by Theodore Ts'o

Subject: Re: [PATCH] ext4: Make seq_operations and file_operations const

On Fri, Sep 04, 2009 at 03:49:36PM +0200, Tobias Klauser wrote:
> Signed-off-by: Tobias Klauser <[email protected]>

Added to the ext4 patch queue.

- Ted