2011-04-14 02:10:56

by Shaohua Li

Subject: [PATCH]ext4: delete dead code

percpu_counter_sum_positive never returns negative.

Signed-off-by: Shaohua Li <[email protected]>

---
fs/ext4/balloc.c | 5 -----
1 file changed, 5 deletions(-)

Index: linux/fs/ext4/balloc.c
===================================================================
--- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
+++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
@@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
EXT4_FREEBLOCKS_WATERMARK) {
free_blocks = percpu_counter_sum_positive(fbc);
dirty_blocks = percpu_counter_sum_positive(dbc);
- if (dirty_blocks < 0) {
- printk(KERN_CRIT "Dirty block accounting "
- "went wrong %lld\n",
- (long long)dirty_blocks);
- }
}
/* Check whether we have space after
* accounting for current dirty blocks & root reserved blocks.

2011-04-15 04:16:15

by Tejun Heo

Subject: Re: [PATCH]ext4: delete dead code

On Thu, Apr 14, 2011 at 10:10:32AM +0800, Shaohua Li wrote:
> percpu_counter_sum_positive never returns negative.
>
> Signed-off-by: Shaohua Li <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Ted, can you please pick this up?

Thanks.

--
tejun

2011-04-18 00:19:21

by Theodore Ts'o

Subject: Re: [PATCH]ext4: delete dead code

On Fri, Apr 15, 2011 at 01:16:10PM +0900, Tejun Heo wrote:
> On Thu, Apr 14, 2011 at 10:10:32AM +0800, Shaohua Li wrote:
> > percpu_counter_sum_positive never returns negative.
> >
> > Signed-off-by: Shaohua Li <[email protected]>
>
> Acked-by: Tejun Heo <[email protected]>
>
> Ted, can you please pick this up?

Added to the ext4 tree.

- Ted