2011-05-23 16:15:50

by Eryu Guan

Subject: [PATCH] jbd: Fix comment to match the code in journal_start()

journal_start returns an ERR_PTR() value rather than NULL on failure.

Cc: Jan Kara <[email protected]>
Signed-off-by: Eryu Guan <[email protected]>
---
fs/jbd/transaction.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 60d2319..f7ee81a 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -266,7 +266,8 @@ static handle_t *new_handle(int nblocks)
* This function is visible to journal users (like ext3fs), so is not
* called with the journal already locked.
*
- * Return a pointer to a newly allocated handle, or NULL on failure
+ * Return a pointer to a newly allocated handle, or an ERR_PTR() value
+ * on failure.
*/
handle_t *journal_start(journal_t *journal, int nblocks)
{
--
1.7.3.4

2011-05-23 22:28:56

by Jan Kara

Subject: Re: [PATCH] jbd: Fix comment to match the code in journal_start()

On Tue 24-05-11 00:17:34, Eryu Guan wrote:
> journal_start returns an ERR_PTR() value rather than NULL on failure.
>
> Cc: Jan Kara <[email protected]>
> Signed-off-by: Eryu Guan <[email protected]>
Tnanks. Merged.

Honza
> ---
> fs/jbd/transaction.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 60d2319..f7ee81a 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -266,7 +266,8 @@ static handle_t *new_handle(int nblocks)
> * This function is visible to journal users (like ext3fs), so is not
> * called with the journal already locked.
> *
> - * Return a pointer to a newly allocated handle, or NULL on failure
> + * Return a pointer to a newly allocated handle, or an ERR_PTR() value
> + * on failure.
> */
> handle_t *journal_start(journal_t *journal, int nblocks)
> {
> --
> 1.7.3.4
>
--
Jan Kara <[email protected]>
SUSE Labs, CR