2011-05-24 20:06:16

by Sage Weil

[permalink] [raw]
Subject: [PATCH 13/19] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir

ext4 has no problems with lingering references to unlinked directory
inodes.

CC: "Theodore Ts'o" <[email protected]>
CC: Andreas Dilger <[email protected]>
CC: [email protected]
Signed-off-by: Sage Weil <[email protected]>
---
fs/ext4/namei.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 792d06e..67fd0b0 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2123,8 +2123,6 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry)
struct ext4_dir_entry_2 *de;
handle_t *handle;

- dentry_unhash(dentry);
-
/* Initialize quotas before so that eventual writes go in
* separate transaction */
dquot_initialize(dir);
@@ -2352,9 +2350,6 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,
struct ext4_dir_entry_2 *old_de, *new_de;
int retval, force_da_alloc = 0;

- if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
- dentry_unhash(new_dentry);
-
dquot_initialize(old_dir);
dquot_initialize(new_dir);

--
1.7.0