2011-06-15 02:25:46

by Robin Dong

Subject: [PATCH] ext4: fix incorrect error msg in ext4_ext_insert_index

In function ext4_ext_insert_index when eh_entries of curp is
bigger than eh_max, error messages will be printed out, but the content
is about logical and ei_block, that's incorret.

Signed-off-by: Robin Dong <[email protected]>
---
fs/ext4/extents.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 5199bac..25be6e0 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -808,8 +808,9 @@ static int ext4_ext_insert_index(handle_t *handle, struct inode *inode,
if (unlikely(le16_to_cpu(curp->p_hdr->eh_entries)
> le16_to_cpu(curp->p_hdr->eh_max))) {
EXT4_ERROR_INODE(inode,
- "logical %d == ei_block %d!",
- logical, le32_to_cpu(curp->p_idx->ei_block));
+ "eh_entries %d > eh_max %d!",
+ le16_to_cpu(curp->p_hdr->eh_entries),
+ le16_to_cpu(curp->p_hdr->eh_max));
return -EIO;
}
if (unlikely(ix > EXT_LAST_INDEX(curp->p_hdr))) {
--
1.7.1

2011-06-27 19:36:54

by Theodore Ts'o

Subject: Re: [PATCH] ext4: fix incorrect error msg in ext4_ext_insert_index

On Wed, Jun 15, 2011 at 10:25:26AM +0800, Robin Dong wrote:
> In function ext4_ext_insert_index when eh_entries of curp is
> bigger than eh_max, error messages will be printed out, but the content
> is about logical and ei_block, that's incorret.
>
> Signed-off-by: Robin Dong <[email protected]>

Added to the ext4 tree, thanks!!

- Ted