2011-07-15 03:52:13

by Allison Henderson

Subject: [PATCH 1/1] XFS TESTS: Correct extent flag parsing for punch hole tests

The fiemap filters used in the punch hole tests parse the
extent flags in the fiemap to determine the extent type.
They are currently parsing them as decimal values, but
they should be parsing hex values.

Signed-off-by: Allison Henderson <[email protected]>
---
:100644 100755 0083963... 0083963... M 255
:100644 100644 a48b7ae... 7337298... M common.punch
common.punch | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/255 b/255
old mode 100644
new mode 100755
diff --git a/common.punch b/common.punch
index a48b7ae..7337298 100644
--- a/common.punch
+++ b/common.punch
@@ -208,11 +208,11 @@ _filter_fiemap()
print $1, $2, $3;
next;
}
- $5 ~ /0x[[:digit:]]*8[[:digit:]]{2}/ {
+ $5 ~ /0x[[:xdigit:]]*8[[:xdigit:]]{2}/ {
print $1, $2, "unwritten";
next;
}
- $5 ~ /0x[[:digit:]]+/ {
+ $5 ~ /0x[[:xdigit:]]+/ {
print $1, $2, "data";
}' |
_coalesce_extents
@@ -228,7 +228,7 @@ _filter_hole_fiemap()
print $1, $2, $3;
next;
}
- $5 ~ /0x[[:digit:]]+/ {
+ $5 ~ /0x[[:xdigit:]]+/ {
print $1, $2, "extent";
}' |
_coalesce_extents
--
1.7.1

2011-07-15 13:46:54

by Alex Elder

Subject: Re: [PATCH 1/1] XFS TESTS: Correct extent flag parsing for punch hole tests

On Thu, 2011-07-14 at 20:52 -0700, Allison Henderson wrote:
> The fiemap filters used in the punch hole tests parse the
> extent flags in the fiemap to determine the extent type.
> They are currently parsing them as decimal values, but
> they should be parsing hex values.
>
> Signed-off-by: Allison Henderson <[email protected]>

Looks good to me. This may not have a practical
effect but it looks correct now.

I will commit this for you. Thanks for fixing it.

Reviewed-by: Alex Elder <[email protected]>