2011-07-27 09:47:46

by Sven Eckelmann

[permalink] [raw]
Subject: [PATCHv4 07/11] ext4: Use *_dec_not_zero instead of *_add_unless

atomic_dec_not_zero is defined for each architecture through
<linux/atomic.h> to provide the functionality of
atomic_add_unless(x, -1, 0).

Signed-off-by: Sven Eckelmann <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Andreas Dilger <[email protected]>
Cc: [email protected]
---
fs/ext4/ext4.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index fa44df8..29996e8 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2098,7 +2098,7 @@ static inline void ext4_lock_group(struct super_block *sb, ext4_group_t group)
* We're able to grab the lock right away, so drop the
* lock contention counter.
*/
- atomic_add_unless(&EXT4_SB(sb)->s_lock_busy, -1, 0);
+ atomic_dec_not_zero(&EXT4_SB(sb)->s_lock_busy);
else {
/*
* The lock is busy, so bump the contention counter,
--
1.7.5.4